diff options
author | Joel Stanley <joel@jms.id.au> | 2018-06-19 01:38:31 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-06-19 18:26:58 -0400 |
commit | 87975a0117815b9b63527e8b8d9a9dffa6913132 (patch) | |
tree | c1a9e78cf8f630bc17862421f4e1d23d8ebc69d3 /net/ncsi | |
parent | c51818d5b793302b0923ade9856574ac28b9333b (diff) |
net/ncsi: Silence debug messages
In normal operation we see this series of messages as the host drives
the network device:
ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down
ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0
ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0
ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config
ftgmac100 1e660000.ethernet eth0: NCSI interface down
ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up
ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0
ftgmac100 1e660000.ethernet eth0: NCSI interface up
ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down
ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0
ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0
ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config
ftgmac100 1e660000.ethernet eth0: NCSI interface down
ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up
ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0
ftgmac100 1e660000.ethernet eth0: NCSI interface up
This makes all of these messages netdev_dbg. They are still useful to
debug eg. misbehaving network device firmware, but we do not need them
filling up the kernel logs in normal operation.
Acked-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ncsi')
-rw-r--r-- | net/ncsi/ncsi-aen.c | 4 | ||||
-rw-r--r-- | net/ncsi/ncsi-manage.c | 14 |
2 files changed, 9 insertions, 9 deletions
diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index e7b05de1e6d1..f899ed61bb57 100644 --- a/net/ncsi/ncsi-aen.c +++ b/net/ncsi/ncsi-aen.c | |||
@@ -73,8 +73,8 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp, | |||
73 | ncm->data[2] = data; | 73 | ncm->data[2] = data; |
74 | ncm->data[4] = ntohl(lsc->oem_status); | 74 | ncm->data[4] = ntohl(lsc->oem_status); |
75 | 75 | ||
76 | netdev_info(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", | 76 | netdev_dbg(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", |
77 | nc->id, data & 0x1 ? "up" : "down"); | 77 | nc->id, data & 0x1 ? "up" : "down"); |
78 | 78 | ||
79 | chained = !list_empty(&nc->link); | 79 | chained = !list_empty(&nc->link); |
80 | state = nc->state; | 80 | state = nc->state; |
diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 5561e221b71f..616441c2b54f 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c | |||
@@ -816,9 +816,9 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) | |||
816 | } else { | 816 | } else { |
817 | hot_nc = NULL; | 817 | hot_nc = NULL; |
818 | nc->state = NCSI_CHANNEL_INACTIVE; | 818 | nc->state = NCSI_CHANNEL_INACTIVE; |
819 | netdev_warn(ndp->ndev.dev, | 819 | netdev_dbg(ndp->ndev.dev, |
820 | "NCSI: channel %u link down after config\n", | 820 | "NCSI: channel %u link down after config\n", |
821 | nc->id); | 821 | nc->id); |
822 | } | 822 | } |
823 | spin_unlock_irqrestore(&nc->lock, flags); | 823 | spin_unlock_irqrestore(&nc->lock, flags); |
824 | 824 | ||
@@ -1199,14 +1199,14 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp) | |||
1199 | switch (old_state) { | 1199 | switch (old_state) { |
1200 | case NCSI_CHANNEL_INACTIVE: | 1200 | case NCSI_CHANNEL_INACTIVE: |
1201 | ndp->ndev.state = ncsi_dev_state_config; | 1201 | ndp->ndev.state = ncsi_dev_state_config; |
1202 | netdev_info(ndp->ndev.dev, "NCSI: configuring channel %u\n", | 1202 | netdev_dbg(ndp->ndev.dev, "NCSI: configuring channel %u\n", |
1203 | nc->id); | 1203 | nc->id); |
1204 | ncsi_configure_channel(ndp); | 1204 | ncsi_configure_channel(ndp); |
1205 | break; | 1205 | break; |
1206 | case NCSI_CHANNEL_ACTIVE: | 1206 | case NCSI_CHANNEL_ACTIVE: |
1207 | ndp->ndev.state = ncsi_dev_state_suspend; | 1207 | ndp->ndev.state = ncsi_dev_state_suspend; |
1208 | netdev_info(ndp->ndev.dev, "NCSI: suspending channel %u\n", | 1208 | netdev_dbg(ndp->ndev.dev, "NCSI: suspending channel %u\n", |
1209 | nc->id); | 1209 | nc->id); |
1210 | ncsi_suspend_channel(ndp); | 1210 | ncsi_suspend_channel(ndp); |
1211 | break; | 1211 | break; |
1212 | default: | 1212 | default: |