diff options
author | Su Yanjun <suyj.fnst@cn.fujitsu.com> | 2019-03-14 02:59:42 -0400 |
---|---|---|
committer | Steffen Klassert <steffen.klassert@secunet.com> | 2019-03-15 06:11:42 -0400 |
commit | 6ee02a54ef990a71bf542b6f0a4e3321de9d9c66 (patch) | |
tree | 37debb665cc4dfa7761e7bf12597b82e512cb28c /net/ipv6 | |
parent | f10e0010fae8174dc20bdc872bcaa85baa925cb7 (diff) |
xfrm6_tunnel: Fix potential panic when unloading xfrm6_tunnel module
When unloading xfrm6_tunnel module, xfrm6_tunnel_fini directly
frees the xfrm6_tunnel_spi_kmem. Maybe someone has gotten the
xfrm6_tunnel_spi, so need to wait it.
Fixes: 91cc3bb0b04ff("xfrm6_tunnel: RCU conversion")
Signed-off-by: Su Yanjun <suyj.fnst@cn.fujitsu.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net/ipv6')
-rw-r--r-- | net/ipv6/xfrm6_tunnel.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c index bc65db782bfb..12cb3aa990af 100644 --- a/net/ipv6/xfrm6_tunnel.c +++ b/net/ipv6/xfrm6_tunnel.c | |||
@@ -402,6 +402,10 @@ static void __exit xfrm6_tunnel_fini(void) | |||
402 | xfrm6_tunnel_deregister(&xfrm6_tunnel_handler, AF_INET6); | 402 | xfrm6_tunnel_deregister(&xfrm6_tunnel_handler, AF_INET6); |
403 | xfrm_unregister_type(&xfrm6_tunnel_type, AF_INET6); | 403 | xfrm_unregister_type(&xfrm6_tunnel_type, AF_INET6); |
404 | unregister_pernet_subsys(&xfrm6_tunnel_net_ops); | 404 | unregister_pernet_subsys(&xfrm6_tunnel_net_ops); |
405 | /* Someone maybe has gotten the xfrm6_tunnel_spi. | ||
406 | * So need to wait it. | ||
407 | */ | ||
408 | rcu_barrier(); | ||
405 | kmem_cache_destroy(xfrm6_tunnel_spi_kmem); | 409 | kmem_cache_destroy(xfrm6_tunnel_spi_kmem); |
406 | } | 410 | } |
407 | 411 | ||