diff options
author | David S. Miller <davem@davemloft.net> | 2018-03-23 11:24:57 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-03-23 11:31:58 -0400 |
commit | 03fe2debbb2771fb90881e4ce8109b09cf772a5c (patch) | |
tree | fbaf8738296b2e9dcba81c6daef2d515b6c4948c /net/core/skbuff.c | |
parent | 6686c459e1449a3ee5f3fd313b0a559ace7a700e (diff) | |
parent | f36b7534b83357cf52e747905de6d65b4f7c2512 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
Fun set of conflict resolutions here...
For the mac80211 stuff, these were fortunately just parallel
adds. Trivially resolved.
In drivers/net/phy/phy.c we had a bug fix in 'net' that moved the
function phy_disable_interrupts() earlier in the file, whilst in
'net-next' the phy_error() call from this function was removed.
In net/ipv4/xfrm4_policy.c, David Ahern's changes to remove the
'rt_table_id' member of rtable collided with a bug fix in 'net' that
added a new struct member "rt_mtu_locked" which needs to be copied
over here.
The mlxsw driver conflict consisted of net-next separating
the span code and definitions into separate files, whilst
a 'net' bug fix made some changes to that moved code.
The mlx5 infiniband conflict resolution was quite non-trivial,
the RDMA tree's merge commit was used as a guide here, and
here are their notes:
====================
Due to bug fixes found by the syzkaller bot and taken into the for-rc
branch after development for the 4.17 merge window had already started
being taken into the for-next branch, there were fairly non-trivial
merge issues that would need to be resolved between the for-rc branch
and the for-next branch. This merge resolves those conflicts and
provides a unified base upon which ongoing development for 4.17 can
be based.
Conflicts:
drivers/infiniband/hw/mlx5/main.c - Commit 42cea83f9524
(IB/mlx5: Fix cleanup order on unload) added to for-rc and
commit b5ca15ad7e61 (IB/mlx5: Add proper representors support)
add as part of the devel cycle both needed to modify the
init/de-init functions used by mlx5. To support the new
representors, the new functions added by the cleanup patch
needed to be made non-static, and the init/de-init list
added by the representors patch needed to be modified to
match the init/de-init list changes made by the cleanup
patch.
Updates:
drivers/infiniband/hw/mlx5/mlx5_ib.h - Update function
prototypes added by representors patch to reflect new function
names as changed by cleanup patch
drivers/infiniband/hw/mlx5/ib_rep.c - Update init/de-init
stage list to match new order from cleanup patch
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/skbuff.c')
-rw-r--r-- | net/core/skbuff.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 715c13495ba6..46cb22215ff4 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c | |||
@@ -4181,7 +4181,7 @@ int sock_queue_err_skb(struct sock *sk, struct sk_buff *skb) | |||
4181 | 4181 | ||
4182 | skb_queue_tail(&sk->sk_error_queue, skb); | 4182 | skb_queue_tail(&sk->sk_error_queue, skb); |
4183 | if (!sock_flag(sk, SOCK_DEAD)) | 4183 | if (!sock_flag(sk, SOCK_DEAD)) |
4184 | sk->sk_data_ready(sk); | 4184 | sk->sk_error_report(sk); |
4185 | return 0; | 4185 | return 0; |
4186 | } | 4186 | } |
4187 | EXPORT_SYMBOL(sock_queue_err_skb); | 4187 | EXPORT_SYMBOL(sock_queue_err_skb); |
@@ -4906,7 +4906,7 @@ static unsigned int skb_gso_transport_seglen(const struct sk_buff *skb) | |||
4906 | thlen += inner_tcp_hdrlen(skb); | 4906 | thlen += inner_tcp_hdrlen(skb); |
4907 | } else if (likely(shinfo->gso_type & (SKB_GSO_TCPV4 | SKB_GSO_TCPV6))) { | 4907 | } else if (likely(shinfo->gso_type & (SKB_GSO_TCPV4 | SKB_GSO_TCPV6))) { |
4908 | thlen = tcp_hdrlen(skb); | 4908 | thlen = tcp_hdrlen(skb); |
4909 | } else if (unlikely(shinfo->gso_type & SKB_GSO_SCTP)) { | 4909 | } else if (unlikely(skb_is_gso_sctp(skb))) { |
4910 | thlen = sizeof(struct sctphdr); | 4910 | thlen = sizeof(struct sctphdr); |
4911 | } | 4911 | } |
4912 | /* UFO sets gso_size to the size of the fragmentation | 4912 | /* UFO sets gso_size to the size of the fragmentation |
@@ -5022,13 +5022,16 @@ EXPORT_SYMBOL_GPL(skb_gso_validate_mac_len); | |||
5022 | 5022 | ||
5023 | static struct sk_buff *skb_reorder_vlan_header(struct sk_buff *skb) | 5023 | static struct sk_buff *skb_reorder_vlan_header(struct sk_buff *skb) |
5024 | { | 5024 | { |
5025 | int mac_len; | ||
5026 | |||
5025 | if (skb_cow(skb, skb_headroom(skb)) < 0) { | 5027 | if (skb_cow(skb, skb_headroom(skb)) < 0) { |
5026 | kfree_skb(skb); | 5028 | kfree_skb(skb); |
5027 | return NULL; | 5029 | return NULL; |
5028 | } | 5030 | } |
5029 | 5031 | ||
5030 | memmove(skb->data - ETH_HLEN, skb->data - skb->mac_len - VLAN_HLEN, | 5032 | mac_len = skb->data - skb_mac_header(skb); |
5031 | 2 * ETH_ALEN); | 5033 | memmove(skb_mac_header(skb) + VLAN_HLEN, skb_mac_header(skb), |
5034 | mac_len - VLAN_HLEN - ETH_TLEN); | ||
5032 | skb->mac_header += VLAN_HLEN; | 5035 | skb->mac_header += VLAN_HLEN; |
5033 | return skb; | 5036 | return skb; |
5034 | } | 5037 | } |