diff options
author | David S. Miller <davem@davemloft.net> | 2018-03-23 11:24:57 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-03-23 11:31:58 -0400 |
commit | 03fe2debbb2771fb90881e4ce8109b09cf772a5c (patch) | |
tree | fbaf8738296b2e9dcba81c6daef2d515b6c4948c /net/core/devlink.c | |
parent | 6686c459e1449a3ee5f3fd313b0a559ace7a700e (diff) | |
parent | f36b7534b83357cf52e747905de6d65b4f7c2512 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
Fun set of conflict resolutions here...
For the mac80211 stuff, these were fortunately just parallel
adds. Trivially resolved.
In drivers/net/phy/phy.c we had a bug fix in 'net' that moved the
function phy_disable_interrupts() earlier in the file, whilst in
'net-next' the phy_error() call from this function was removed.
In net/ipv4/xfrm4_policy.c, David Ahern's changes to remove the
'rt_table_id' member of rtable collided with a bug fix in 'net' that
added a new struct member "rt_mtu_locked" which needs to be copied
over here.
The mlxsw driver conflict consisted of net-next separating
the span code and definitions into separate files, whilst
a 'net' bug fix made some changes to that moved code.
The mlx5 infiniband conflict resolution was quite non-trivial,
the RDMA tree's merge commit was used as a guide here, and
here are their notes:
====================
Due to bug fixes found by the syzkaller bot and taken into the for-rc
branch after development for the 4.17 merge window had already started
being taken into the for-next branch, there were fairly non-trivial
merge issues that would need to be resolved between the for-rc branch
and the for-next branch. This merge resolves those conflicts and
provides a unified base upon which ongoing development for 4.17 can
be based.
Conflicts:
drivers/infiniband/hw/mlx5/main.c - Commit 42cea83f9524
(IB/mlx5: Fix cleanup order on unload) added to for-rc and
commit b5ca15ad7e61 (IB/mlx5: Add proper representors support)
add as part of the devel cycle both needed to modify the
init/de-init functions used by mlx5. To support the new
representors, the new functions added by the cleanup patch
needed to be made non-static, and the init/de-init list
added by the representors patch needed to be modified to
match the init/de-init list changes made by the cleanup
patch.
Updates:
drivers/infiniband/hw/mlx5/mlx5_ib.h - Update function
prototypes added by representors patch to reflect new function
names as changed by cleanup patch
drivers/infiniband/hw/mlx5/ib_rep.c - Update init/de-init
stage list to match new order from cleanup patch
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/devlink.c')
-rw-r--r-- | net/core/devlink.c | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/net/core/devlink.c b/net/core/devlink.c index d03b96f87c25..9236e421bd62 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c | |||
@@ -1798,7 +1798,7 @@ send_done: | |||
1798 | if (!nlh) { | 1798 | if (!nlh) { |
1799 | err = devlink_dpipe_send_and_alloc_skb(&skb, info); | 1799 | err = devlink_dpipe_send_and_alloc_skb(&skb, info); |
1800 | if (err) | 1800 | if (err) |
1801 | goto err_skb_send_alloc; | 1801 | return err; |
1802 | goto send_done; | 1802 | goto send_done; |
1803 | } | 1803 | } |
1804 | 1804 | ||
@@ -1807,7 +1807,6 @@ send_done: | |||
1807 | nla_put_failure: | 1807 | nla_put_failure: |
1808 | err = -EMSGSIZE; | 1808 | err = -EMSGSIZE; |
1809 | err_table_put: | 1809 | err_table_put: |
1810 | err_skb_send_alloc: | ||
1811 | genlmsg_cancel(skb, hdr); | 1810 | genlmsg_cancel(skb, hdr); |
1812 | nlmsg_free(skb); | 1811 | nlmsg_free(skb); |
1813 | return err; | 1812 | return err; |
@@ -2073,7 +2072,7 @@ static int devlink_dpipe_entries_fill(struct genl_info *info, | |||
2073 | table->counters_enabled, | 2072 | table->counters_enabled, |
2074 | &dump_ctx); | 2073 | &dump_ctx); |
2075 | if (err) | 2074 | if (err) |
2076 | goto err_entries_dump; | 2075 | return err; |
2077 | 2076 | ||
2078 | send_done: | 2077 | send_done: |
2079 | nlh = nlmsg_put(dump_ctx.skb, info->snd_portid, info->snd_seq, | 2078 | nlh = nlmsg_put(dump_ctx.skb, info->snd_portid, info->snd_seq, |
@@ -2081,16 +2080,10 @@ send_done: | |||
2081 | if (!nlh) { | 2080 | if (!nlh) { |
2082 | err = devlink_dpipe_send_and_alloc_skb(&dump_ctx.skb, info); | 2081 | err = devlink_dpipe_send_and_alloc_skb(&dump_ctx.skb, info); |
2083 | if (err) | 2082 | if (err) |
2084 | goto err_skb_send_alloc; | 2083 | return err; |
2085 | goto send_done; | 2084 | goto send_done; |
2086 | } | 2085 | } |
2087 | return genlmsg_reply(dump_ctx.skb, info); | 2086 | return genlmsg_reply(dump_ctx.skb, info); |
2088 | |||
2089 | err_entries_dump: | ||
2090 | err_skb_send_alloc: | ||
2091 | genlmsg_cancel(dump_ctx.skb, dump_ctx.hdr); | ||
2092 | nlmsg_free(dump_ctx.skb); | ||
2093 | return err; | ||
2094 | } | 2087 | } |
2095 | 2088 | ||
2096 | static int devlink_nl_cmd_dpipe_entries_get(struct sk_buff *skb, | 2089 | static int devlink_nl_cmd_dpipe_entries_get(struct sk_buff *skb, |
@@ -2229,7 +2222,7 @@ send_done: | |||
2229 | if (!nlh) { | 2222 | if (!nlh) { |
2230 | err = devlink_dpipe_send_and_alloc_skb(&skb, info); | 2223 | err = devlink_dpipe_send_and_alloc_skb(&skb, info); |
2231 | if (err) | 2224 | if (err) |
2232 | goto err_skb_send_alloc; | 2225 | return err; |
2233 | goto send_done; | 2226 | goto send_done; |
2234 | } | 2227 | } |
2235 | return genlmsg_reply(skb, info); | 2228 | return genlmsg_reply(skb, info); |
@@ -2237,7 +2230,6 @@ send_done: | |||
2237 | nla_put_failure: | 2230 | nla_put_failure: |
2238 | err = -EMSGSIZE; | 2231 | err = -EMSGSIZE; |
2239 | err_table_put: | 2232 | err_table_put: |
2240 | err_skb_send_alloc: | ||
2241 | genlmsg_cancel(skb, hdr); | 2233 | genlmsg_cancel(skb, hdr); |
2242 | nlmsg_free(skb); | 2234 | nlmsg_free(skb); |
2243 | return err; | 2235 | return err; |