aboutsummaryrefslogtreecommitdiffstats
path: root/net/can/raw.c
diff options
context:
space:
mode:
authorSteffen Hurrle <steffen@hurrle.net>2014-01-17 16:53:15 -0500
committerDavid S. Miller <davem@davemloft.net>2014-01-19 02:04:16 -0500
commit342dfc306fb32155314dad277f3c3686b83fb9f1 (patch)
treea0d220f9310725c72bac70945261c9282e7cf305 /net/can/raw.c
parentea02f9411d9faa3553ed09ce0ec9f00ceae9885e (diff)
net: add build-time checks for msg->msg_name size
This is a follow-up patch to f3d3342602f8bc ("net: rework recvmsg handler msg_name and msg_namelen logic"). DECLARE_SOCKADDR validates that the structure we use for writing the name information to is not larger than the buffer which is reserved for msg->msg_name (which is 128 bytes). Also use DECLARE_SOCKADDR consistently in sendmsg code paths. Signed-off-by: Steffen Hurrle <steffen@hurrle.net> Suggested-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/can/raw.c')
-rw-r--r--net/can/raw.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/can/raw.c b/net/can/raw.c
index 641e1c895123..07d72d852324 100644
--- a/net/can/raw.c
+++ b/net/can/raw.c
@@ -675,8 +675,7 @@ static int raw_sendmsg(struct kiocb *iocb, struct socket *sock,
675 int err; 675 int err;
676 676
677 if (msg->msg_name) { 677 if (msg->msg_name) {
678 struct sockaddr_can *addr = 678 DECLARE_SOCKADDR(struct sockaddr_can *, addr, msg->msg_name);
679 (struct sockaddr_can *)msg->msg_name;
680 679
681 if (msg->msg_namelen < sizeof(*addr)) 680 if (msg->msg_namelen < sizeof(*addr))
682 return -EINVAL; 681 return -EINVAL;
@@ -775,6 +774,7 @@ static int raw_recvmsg(struct kiocb *iocb, struct socket *sock,
775 sock_recv_ts_and_drops(msg, sk, skb); 774 sock_recv_ts_and_drops(msg, sk, skb);
776 775
777 if (msg->msg_name) { 776 if (msg->msg_name) {
777 __sockaddr_check_size(sizeof(struct sockaddr_can));
778 msg->msg_namelen = sizeof(struct sockaddr_can); 778 msg->msg_namelen = sizeof(struct sockaddr_can);
779 memcpy(msg->msg_name, skb->cb, msg->msg_namelen); 779 memcpy(msg->msg_name, skb->cb, msg->msg_namelen);
780 } 780 }