diff options
author | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2018-11-18 17:10:15 -0500 |
---|---|---|
committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2018-11-26 16:18:04 -0500 |
commit | 8114865ff82e200b383e46821c25cb0625b842b5 (patch) | |
tree | 88cbfcc66e0a8013ef4a4eed6141730aee75f6ee /kernel/trace/trace_functions_graph.c | |
parent | 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6 (diff) |
function_graph: Create function_graph_enter() to consolidate architecture code
Currently all the architectures do basically the same thing in preparing the
function graph tracer on entry to a function. This code can be pulled into a
generic location and then this will allow the function graph tracer to be
fixed, as well as extended.
Create a new function graph helper function_graph_enter() that will call the
hook function (ftrace_graph_entry) and the shadow stack operation
(ftrace_push_return_trace), and remove the need of the architecture code to
manage the shadow stack.
This is needed to prepare for a fix of a design bug on how the curr_ret_stack
is used.
Cc: stable@kernel.org
Fixes: 03274a3ffb449 ("tracing/fgraph: Adjust fgraph depth before calling trace return callback")
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_functions_graph.c')
-rw-r--r-- | kernel/trace/trace_functions_graph.c | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index 169b3c44ee97..28f2602435d0 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c | |||
@@ -182,6 +182,22 @@ ftrace_push_return_trace(unsigned long ret, unsigned long func, int *depth, | |||
182 | return 0; | 182 | return 0; |
183 | } | 183 | } |
184 | 184 | ||
185 | int function_graph_enter(unsigned long ret, unsigned long func, | ||
186 | unsigned long frame_pointer, unsigned long *retp) | ||
187 | { | ||
188 | struct ftrace_graph_ent trace; | ||
189 | |||
190 | trace.func = func; | ||
191 | trace.depth = current->curr_ret_stack + 1; | ||
192 | |||
193 | /* Only trace if the calling function expects to */ | ||
194 | if (!ftrace_graph_entry(&trace)) | ||
195 | return -EBUSY; | ||
196 | |||
197 | return ftrace_push_return_trace(ret, func, &trace.depth, | ||
198 | frame_pointer, retp); | ||
199 | } | ||
200 | |||
185 | /* Retrieve a function return address to the trace stack on thread info.*/ | 201 | /* Retrieve a function return address to the trace stack on thread info.*/ |
186 | static void | 202 | static void |
187 | ftrace_pop_return_trace(struct ftrace_graph_ret *trace, unsigned long *ret, | 203 | ftrace_pop_return_trace(struct ftrace_graph_ret *trace, unsigned long *ret, |