aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/rcu/tree.c
diff options
context:
space:
mode:
authorJoel Fernandes (Google) <joel@joelfernandes.org>2018-05-13 23:15:41 -0400
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2018-07-12 18:38:53 -0400
commit5ca0905f6787e930bc2a626cf1d8f69fab52acef (patch)
tree5bcacd1ddb00b2596b86905b4f2b764ae0a7d8db /kernel/rcu/tree.c
parent5b55072f22ba2ed136b7a1b6c5beea9ace8415a7 (diff)
rcu: Fix cpustart tracepoint gp_seq number
The "cpustart" trace event shows a stale gp_seq. This is because it uses rdp->gp_seq, which is updated only at the end of the __note_gp_changes() function. This commit therefore instead uses rnp->gp_seq. An alternative fix would be to update rdp->gp_seq earlier, but this would break RCU's detection of the beginning of a new-to-this-CPU grace period. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'kernel/rcu/tree.c')
-rw-r--r--kernel/rcu/tree.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 73a33b82cfcd..973250503d98 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1801,7 +1801,7 @@ static bool __note_gp_changes(struct rcu_state *rsp, struct rcu_node *rnp,
1801 * set up to detect a quiescent state, otherwise don't 1801 * set up to detect a quiescent state, otherwise don't
1802 * go looking for one. 1802 * go looking for one.
1803 */ 1803 */
1804 trace_rcu_grace_period(rsp->name, rdp->gp_seq, TPS("cpustart")); 1804 trace_rcu_grace_period(rsp->name, rnp->gp_seq, TPS("cpustart"));
1805 need_gp = !!(rnp->qsmask & rdp->grpmask); 1805 need_gp = !!(rnp->qsmask & rdp->grpmask);
1806 rdp->cpu_no_qs.b.norm = need_gp; 1806 rdp->cpu_no_qs.b.norm = need_gp;
1807 rdp->rcu_qs_ctr_snap = __this_cpu_read(rcu_dynticks.rcu_qs_ctr); 1807 rdp->rcu_qs_ctr_snap = __this_cpu_read(rcu_dynticks.rcu_qs_ctr);