diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2011-11-14 07:13:49 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2011-12-06 02:16:47 -0500 |
commit | df754e6af2f237a6c020c0daff55a1a609338e31 (patch) | |
tree | 138bfed4fccbba3671473a6768c91a9c3b9b8e84 /kernel/panic.c | |
parent | 7119a341f35b0a3ddcf426818267980057c770a1 (diff) |
lockdep, bug: Exclude TAINT_FIRMWARE_WORKAROUND from disabling lockdep
It's unlikely that TAINT_FIRMWARE_WORKAROUND causes false
lockdep messages, so do not disable lockdep in that case.
We still want to keep lockdep disabled in the
TAINT_OOT_MODULE case:
- bin-only modules can cause various instabilities in
their and in unrelated kernel code
- they are impossible to debug for kernel developers
- they also typically do not have the copyright license
permission to link to the GPL-ed lockdep code.
Suggested-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-xopopjjens57r0i13qnyh2yo@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/panic.c')
-rw-r--r-- | kernel/panic.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/kernel/panic.c b/kernel/panic.c index b26593604214..1b83fd80b569 100644 --- a/kernel/panic.c +++ b/kernel/panic.c | |||
@@ -240,8 +240,16 @@ void add_taint(unsigned flag) | |||
240 | * Also we want to keep up lockdep for staging development and | 240 | * Also we want to keep up lockdep for staging development and |
241 | * post-warning case. | 241 | * post-warning case. |
242 | */ | 242 | */ |
243 | if (flag != TAINT_CRAP && flag != TAINT_WARN && __debug_locks_off()) | 243 | switch (flag) { |
244 | printk(KERN_WARNING "Disabling lock debugging due to kernel taint\n"); | 244 | case TAINT_CRAP: |
245 | case TAINT_WARN: | ||
246 | case TAINT_FIRMWARE_WORKAROUND: | ||
247 | break; | ||
248 | |||
249 | default: | ||
250 | if (__debug_locks_off()) | ||
251 | printk(KERN_WARNING "Disabling lock debugging due to kernel taint\n"); | ||
252 | } | ||
245 | 253 | ||
246 | set_bit(flag, &tainted_mask); | 254 | set_bit(flag, &tainted_mask); |
247 | } | 255 | } |