diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2019-05-12 17:46:05 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2019-05-25 18:00:00 -0400 |
commit | 709a643da8b8c5fc823e1870d8227ca0eeb51311 (patch) | |
tree | b58fcd3e635d2949f903a1f6bd5d3308a99ee036 /ipc | |
parent | 20284ab7427ffac514faf44fd9eb50e5745f4474 (diff) |
mqueue: set ->user_ns before ->get_tree()
... so that we could lift the capability checks into ->get_tree()
caller
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'ipc')
-rw-r--r-- | ipc/mqueue.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/ipc/mqueue.c b/ipc/mqueue.c index 216cad1ff0d0..9f8e4cbcec00 100644 --- a/ipc/mqueue.c +++ b/ipc/mqueue.c | |||
@@ -364,8 +364,6 @@ static int mqueue_get_tree(struct fs_context *fc) | |||
364 | { | 364 | { |
365 | struct mqueue_fs_context *ctx = fc->fs_private; | 365 | struct mqueue_fs_context *ctx = fc->fs_private; |
366 | 366 | ||
367 | put_user_ns(fc->user_ns); | ||
368 | fc->user_ns = get_user_ns(ctx->ipc_ns->user_ns); | ||
369 | fc->s_fs_info = ctx->ipc_ns; | 367 | fc->s_fs_info = ctx->ipc_ns; |
370 | return vfs_get_super(fc, vfs_get_keyed_super, mqueue_fill_super); | 368 | return vfs_get_super(fc, vfs_get_keyed_super, mqueue_fill_super); |
371 | } | 369 | } |
@@ -374,8 +372,7 @@ static void mqueue_fs_context_free(struct fs_context *fc) | |||
374 | { | 372 | { |
375 | struct mqueue_fs_context *ctx = fc->fs_private; | 373 | struct mqueue_fs_context *ctx = fc->fs_private; |
376 | 374 | ||
377 | if (ctx->ipc_ns) | 375 | put_ipc_ns(ctx->ipc_ns); |
378 | put_ipc_ns(ctx->ipc_ns); | ||
379 | kfree(ctx); | 376 | kfree(ctx); |
380 | } | 377 | } |
381 | 378 | ||
@@ -388,6 +385,8 @@ static int mqueue_init_fs_context(struct fs_context *fc) | |||
388 | return -ENOMEM; | 385 | return -ENOMEM; |
389 | 386 | ||
390 | ctx->ipc_ns = get_ipc_ns(current->nsproxy->ipc_ns); | 387 | ctx->ipc_ns = get_ipc_ns(current->nsproxy->ipc_ns); |
388 | put_user_ns(fc->user_ns); | ||
389 | fc->user_ns = get_user_ns(ctx->ipc_ns->user_ns); | ||
391 | fc->fs_private = ctx; | 390 | fc->fs_private = ctx; |
392 | fc->ops = &mqueue_fs_context_ops; | 391 | fc->ops = &mqueue_fs_context_ops; |
393 | return 0; | 392 | return 0; |
@@ -406,6 +405,8 @@ static struct vfsmount *mq_create_mount(struct ipc_namespace *ns) | |||
406 | ctx = fc->fs_private; | 405 | ctx = fc->fs_private; |
407 | put_ipc_ns(ctx->ipc_ns); | 406 | put_ipc_ns(ctx->ipc_ns); |
408 | ctx->ipc_ns = get_ipc_ns(ns); | 407 | ctx->ipc_ns = get_ipc_ns(ns); |
408 | put_user_ns(fc->user_ns); | ||
409 | fc->user_ns = get_user_ns(ctx->ipc_ns->user_ns); | ||
409 | 410 | ||
410 | mnt = fc_mount(fc); | 411 | mnt = fc_mount(fc); |
411 | put_fs_context(fc); | 412 | put_fs_context(fc); |