diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2019-02-22 13:25:59 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-02-24 20:33:59 -0500 |
| commit | e728fdf0628971d43cb4e48860defc6e8a553761 (patch) | |
| tree | 02d60c34b9d0d259f959bd79da9b820129f5e266 /include/uapi/linux/ethtool.h | |
| parent | fad4271bec382a7a985ba9c1b31c85611ec90708 (diff) | |
net: phy: improve definition of __ETHTOOL_LINK_MODE_MASK_NBITS
The way to define __ETHTOOL_LINK_MODE_MASK_NBITS seems to be overly
complicated, go with a standard approach instead.
Whilst we're at it, move the comment to the right place.
v2:
- rebased
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi/linux/ethtool.h')
| -rw-r--r-- | include/uapi/linux/ethtool.h | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 378c52308d89..3652b239dad1 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h | |||
| @@ -1432,6 +1432,13 @@ enum ethtool_link_mode_bit_indices { | |||
| 1432 | ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT = 29, | 1432 | ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT = 29, |
| 1433 | ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT = 30, | 1433 | ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT = 30, |
| 1434 | ETHTOOL_LINK_MODE_25000baseCR_Full_BIT = 31, | 1434 | ETHTOOL_LINK_MODE_25000baseCR_Full_BIT = 31, |
| 1435 | |||
| 1436 | /* Last allowed bit for __ETHTOOL_LINK_MODE_LEGACY_MASK is bit | ||
| 1437 | * 31. Please do NOT define any SUPPORTED_* or ADVERTISED_* | ||
| 1438 | * macro for bits > 31. The only way to use indices > 31 is to | ||
| 1439 | * use the new ETHTOOL_GLINKSETTINGS/ETHTOOL_SLINKSETTINGS API. | ||
| 1440 | */ | ||
| 1441 | |||
| 1435 | ETHTOOL_LINK_MODE_25000baseKR_Full_BIT = 32, | 1442 | ETHTOOL_LINK_MODE_25000baseKR_Full_BIT = 32, |
| 1436 | ETHTOOL_LINK_MODE_25000baseSR_Full_BIT = 33, | 1443 | ETHTOOL_LINK_MODE_25000baseSR_Full_BIT = 33, |
| 1437 | ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT = 34, | 1444 | ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT = 34, |
| @@ -1469,14 +1476,8 @@ enum ethtool_link_mode_bit_indices { | |||
| 1469 | ETHTOOL_LINK_MODE_200000baseDR4_Full_BIT = 65, | 1476 | ETHTOOL_LINK_MODE_200000baseDR4_Full_BIT = 65, |
| 1470 | ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT = 66, | 1477 | ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT = 66, |
| 1471 | 1478 | ||
| 1472 | /* Last allowed bit for __ETHTOOL_LINK_MODE_LEGACY_MASK is bit | 1479 | /* must be last entry */ |
| 1473 | * 31. Please do NOT define any SUPPORTED_* or ADVERTISED_* | 1480 | __ETHTOOL_LINK_MODE_MASK_NBITS |
| 1474 | * macro for bits > 31. The only way to use indices > 31 is to | ||
| 1475 | * use the new ETHTOOL_GLINKSETTINGS/ETHTOOL_SLINKSETTINGS API. | ||
| 1476 | */ | ||
| 1477 | |||
| 1478 | __ETHTOOL_LINK_MODE_LAST | ||
| 1479 | = ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT, | ||
| 1480 | }; | 1481 | }; |
| 1481 | 1482 | ||
| 1482 | #define __ETHTOOL_LINK_MODE_LEGACY_MASK(base_name) \ | 1483 | #define __ETHTOOL_LINK_MODE_LEGACY_MASK(base_name) \ |
