diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2019-07-16 18:15:29 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-07-16 18:15:29 -0400 |
commit | 0a8ad0ffa4d80a544f6cbff703bf6394339afcdf (patch) | |
tree | 79558167c6e8c5c059a54625c3be5395b95adcaa /fs | |
parent | a18f8775419d3df282dd83efdb51c5a64d092f31 (diff) | |
parent | e65682b55956e9fbf8a88f303a48e7c1430ffe15 (diff) |
Merge tag 'for-linus-5.3-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux
Pull orangefs updates from Mike Marshall:
"Two small fixes.
This is just a fix for an unused value that Colin King sent me and a
related fix I added"
* tag 'for-linus-5.3-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux:
orangefs: eliminate needless variable assignments
orangefs: remove redundant assignment to variable buffer_index
Diffstat (limited to 'fs')
-rw-r--r-- | fs/orangefs/file.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c index 679a3c8e4fb3..960f9a3c012d 100644 --- a/fs/orangefs/file.c +++ b/fs/orangefs/file.c | |||
@@ -52,7 +52,7 @@ ssize_t wait_for_direct_io(enum ORANGEFS_io_type type, struct inode *inode, | |||
52 | struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode); | 52 | struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode); |
53 | struct orangefs_khandle *handle = &orangefs_inode->refn.khandle; | 53 | struct orangefs_khandle *handle = &orangefs_inode->refn.khandle; |
54 | struct orangefs_kernel_op_s *new_op = NULL; | 54 | struct orangefs_kernel_op_s *new_op = NULL; |
55 | int buffer_index = -1; | 55 | int buffer_index; |
56 | ssize_t ret; | 56 | ssize_t ret; |
57 | size_t copy_amount; | 57 | size_t copy_amount; |
58 | 58 | ||
@@ -134,7 +134,6 @@ populate_shared_memory: | |||
134 | */ | 134 | */ |
135 | if (ret == -EAGAIN && op_state_purged(new_op)) { | 135 | if (ret == -EAGAIN && op_state_purged(new_op)) { |
136 | orangefs_bufmap_put(buffer_index); | 136 | orangefs_bufmap_put(buffer_index); |
137 | buffer_index = -1; | ||
138 | if (type == ORANGEFS_IO_WRITE) | 137 | if (type == ORANGEFS_IO_WRITE) |
139 | iov_iter_revert(iter, total_size); | 138 | iov_iter_revert(iter, total_size); |
140 | gossip_debug(GOSSIP_FILE_DEBUG, | 139 | gossip_debug(GOSSIP_FILE_DEBUG, |
@@ -262,7 +261,6 @@ out: | |||
262 | "%s(%pU): PUT buffer_index %d\n", | 261 | "%s(%pU): PUT buffer_index %d\n", |
263 | __func__, handle, buffer_index); | 262 | __func__, handle, buffer_index); |
264 | } | 263 | } |
265 | buffer_index = -1; | ||
266 | } | 264 | } |
267 | op_release(new_op); | 265 | op_release(new_op); |
268 | return ret; | 266 | return ret; |