diff options
author | Christoph Hellwig <hch@lst.de> | 2019-06-12 11:59:59 -0400 |
---|---|---|
committer | Darrick J. Wong <darrick.wong@oracle.com> | 2019-06-12 11:59:59 -0400 |
commit | 76dee76921e138d93dba7aaabece13f2c3c1219f (patch) | |
tree | cb77078f67ff04260eb74a1c0501ffe819fd6d1f /fs/xfs | |
parent | f9a196ee5ab517deff40ae57195416c13c44c13f (diff) |
xfs: remove the debug-only q_transp field from struct xfs_dquot
The field is only used for a few assertations. Shrink the dqout
structure instead, similarly to what commit f3ca87389dbf
("xfs: remove i_transp") did for the xfs_inode.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r-- | fs/xfs/xfs_dquot.h | 1 | ||||
-rw-r--r-- | fs/xfs/xfs_dquot_item.c | 5 | ||||
-rw-r--r-- | fs/xfs/xfs_trans_dquot.c | 10 |
3 files changed, 0 insertions, 16 deletions
diff --git a/fs/xfs/xfs_dquot.h b/fs/xfs/xfs_dquot.h index 64bd8640f6e8..4fe85709d55d 100644 --- a/fs/xfs/xfs_dquot.h +++ b/fs/xfs/xfs_dquot.h | |||
@@ -34,7 +34,6 @@ typedef struct xfs_dquot { | |||
34 | uint dq_flags; /* various flags (XFS_DQ_*) */ | 34 | uint dq_flags; /* various flags (XFS_DQ_*) */ |
35 | struct list_head q_lru; /* global free list of dquots */ | 35 | struct list_head q_lru; /* global free list of dquots */ |
36 | struct xfs_mount*q_mount; /* filesystem this relates to */ | 36 | struct xfs_mount*q_mount; /* filesystem this relates to */ |
37 | struct xfs_trans*q_transp; /* trans this belongs to currently */ | ||
38 | uint q_nrefs; /* # active refs from inodes */ | 37 | uint q_nrefs; /* # active refs from inodes */ |
39 | xfs_daddr_t q_blkno; /* blkno of dquot buffer */ | 38 | xfs_daddr_t q_blkno; /* blkno of dquot buffer */ |
40 | int q_bufoffset; /* off of dq in buffer (# dquots) */ | 39 | int q_bufoffset; /* off of dq in buffer (# dquots) */ |
diff --git a/fs/xfs/xfs_dquot_item.c b/fs/xfs/xfs_dquot_item.c index 7dedd17c4813..87b23ae44397 100644 --- a/fs/xfs/xfs_dquot_item.c +++ b/fs/xfs/xfs_dquot_item.c | |||
@@ -224,11 +224,6 @@ xfs_qm_dquot_logitem_unlock( | |||
224 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); | 224 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); |
225 | 225 | ||
226 | /* | 226 | /* |
227 | * Clear the transaction pointer in the dquot | ||
228 | */ | ||
229 | dqp->q_transp = NULL; | ||
230 | |||
231 | /* | ||
232 | * dquots are never 'held' from getting unlocked at the end of | 227 | * dquots are never 'held' from getting unlocked at the end of |
233 | * a transaction. Their locking and unlocking is hidden inside the | 228 | * a transaction. Their locking and unlocking is hidden inside the |
234 | * transaction layer, within trans_commit. Hence, no LI_HOLD flag | 229 | * transaction layer, within trans_commit. Hence, no LI_HOLD flag |
diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c index cd664a03613f..ba3de1f03b98 100644 --- a/fs/xfs/xfs_trans_dquot.c +++ b/fs/xfs/xfs_trans_dquot.c | |||
@@ -29,7 +29,6 @@ xfs_trans_dqjoin( | |||
29 | xfs_trans_t *tp, | 29 | xfs_trans_t *tp, |
30 | xfs_dquot_t *dqp) | 30 | xfs_dquot_t *dqp) |
31 | { | 31 | { |
32 | ASSERT(dqp->q_transp != tp); | ||
33 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); | 32 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); |
34 | ASSERT(dqp->q_logitem.qli_dquot == dqp); | 33 | ASSERT(dqp->q_logitem.qli_dquot == dqp); |
35 | 34 | ||
@@ -37,15 +36,8 @@ xfs_trans_dqjoin( | |||
37 | * Get a log_item_desc to point at the new item. | 36 | * Get a log_item_desc to point at the new item. |
38 | */ | 37 | */ |
39 | xfs_trans_add_item(tp, &dqp->q_logitem.qli_item); | 38 | xfs_trans_add_item(tp, &dqp->q_logitem.qli_item); |
40 | |||
41 | /* | ||
42 | * Initialize d_transp so we can later determine if this dquot is | ||
43 | * associated with this transaction. | ||
44 | */ | ||
45 | dqp->q_transp = tp; | ||
46 | } | 39 | } |
47 | 40 | ||
48 | |||
49 | /* | 41 | /* |
50 | * This is called to mark the dquot as needing | 42 | * This is called to mark the dquot as needing |
51 | * to be logged when the transaction is committed. The dquot must | 43 | * to be logged when the transaction is committed. The dquot must |
@@ -61,7 +53,6 @@ xfs_trans_log_dquot( | |||
61 | xfs_trans_t *tp, | 53 | xfs_trans_t *tp, |
62 | xfs_dquot_t *dqp) | 54 | xfs_dquot_t *dqp) |
63 | { | 55 | { |
64 | ASSERT(dqp->q_transp == tp); | ||
65 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); | 56 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); |
66 | 57 | ||
67 | tp->t_flags |= XFS_TRANS_DIRTY; | 58 | tp->t_flags |= XFS_TRANS_DIRTY; |
@@ -347,7 +338,6 @@ xfs_trans_apply_dquot_deltas( | |||
347 | break; | 338 | break; |
348 | 339 | ||
349 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); | 340 | ASSERT(XFS_DQ_IS_LOCKED(dqp)); |
350 | ASSERT(dqp->q_transp == tp); | ||
351 | 341 | ||
352 | /* | 342 | /* |
353 | * adjust the actual number of blocks used | 343 | * adjust the actual number of blocks used |