diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2016-01-22 15:40:57 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2016-01-22 18:04:28 -0500 |
commit | 5955102c9984fa081b2d570cfac75c97eecf8f3b (patch) | |
tree | a4744386eac4b916e847eb4eedfada158f6527b4 /fs/ubifs | |
parent | 57b8f112cfe6622ddddb8c2641206bb5fa8a112d (diff) |
wrappers for ->i_mutex access
parallel to mutex_{lock,unlock,trylock,is_locked,lock_nested},
inode_foo(inode) being mutex_foo(&inode->i_mutex).
Please, use those for access to ->i_mutex; over the coming cycle
->i_mutex will become rwsem, with ->lookup() done with it held
only shared.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ubifs')
-rw-r--r-- | fs/ubifs/dir.c | 18 | ||||
-rw-r--r-- | fs/ubifs/file.c | 4 | ||||
-rw-r--r-- | fs/ubifs/xattr.c | 4 |
3 files changed, 13 insertions, 13 deletions
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index e49bd2808bf3..795992a8321e 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c | |||
@@ -515,8 +515,8 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir, | |||
515 | dbg_gen("dent '%pd' to ino %lu (nlink %d) in dir ino %lu", | 515 | dbg_gen("dent '%pd' to ino %lu (nlink %d) in dir ino %lu", |
516 | dentry, inode->i_ino, | 516 | dentry, inode->i_ino, |
517 | inode->i_nlink, dir->i_ino); | 517 | inode->i_nlink, dir->i_ino); |
518 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); | 518 | ubifs_assert(inode_is_locked(dir)); |
519 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); | 519 | ubifs_assert(inode_is_locked(inode)); |
520 | 520 | ||
521 | err = dbg_check_synced_i_size(c, inode); | 521 | err = dbg_check_synced_i_size(c, inode); |
522 | if (err) | 522 | if (err) |
@@ -572,8 +572,8 @@ static int ubifs_unlink(struct inode *dir, struct dentry *dentry) | |||
572 | dbg_gen("dent '%pd' from ino %lu (nlink %d) in dir ino %lu", | 572 | dbg_gen("dent '%pd' from ino %lu (nlink %d) in dir ino %lu", |
573 | dentry, inode->i_ino, | 573 | dentry, inode->i_ino, |
574 | inode->i_nlink, dir->i_ino); | 574 | inode->i_nlink, dir->i_ino); |
575 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); | 575 | ubifs_assert(inode_is_locked(dir)); |
576 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); | 576 | ubifs_assert(inode_is_locked(inode)); |
577 | err = dbg_check_synced_i_size(c, inode); | 577 | err = dbg_check_synced_i_size(c, inode); |
578 | if (err) | 578 | if (err) |
579 | return err; | 579 | return err; |
@@ -661,8 +661,8 @@ static int ubifs_rmdir(struct inode *dir, struct dentry *dentry) | |||
661 | 661 | ||
662 | dbg_gen("directory '%pd', ino %lu in dir ino %lu", dentry, | 662 | dbg_gen("directory '%pd', ino %lu in dir ino %lu", dentry, |
663 | inode->i_ino, dir->i_ino); | 663 | inode->i_ino, dir->i_ino); |
664 | ubifs_assert(mutex_is_locked(&dir->i_mutex)); | 664 | ubifs_assert(inode_is_locked(dir)); |
665 | ubifs_assert(mutex_is_locked(&inode->i_mutex)); | 665 | ubifs_assert(inode_is_locked(inode)); |
666 | err = check_dir_empty(c, d_inode(dentry)); | 666 | err = check_dir_empty(c, d_inode(dentry)); |
667 | if (err) | 667 | if (err) |
668 | return err; | 668 | return err; |
@@ -996,10 +996,10 @@ static int ubifs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
996 | dbg_gen("dent '%pd' ino %lu in dir ino %lu to dent '%pd' in dir ino %lu", | 996 | dbg_gen("dent '%pd' ino %lu in dir ino %lu to dent '%pd' in dir ino %lu", |
997 | old_dentry, old_inode->i_ino, old_dir->i_ino, | 997 | old_dentry, old_inode->i_ino, old_dir->i_ino, |
998 | new_dentry, new_dir->i_ino); | 998 | new_dentry, new_dir->i_ino); |
999 | ubifs_assert(mutex_is_locked(&old_dir->i_mutex)); | 999 | ubifs_assert(inode_is_locked(old_dir)); |
1000 | ubifs_assert(mutex_is_locked(&new_dir->i_mutex)); | 1000 | ubifs_assert(inode_is_locked(new_dir)); |
1001 | if (unlink) | 1001 | if (unlink) |
1002 | ubifs_assert(mutex_is_locked(&new_inode->i_mutex)); | 1002 | ubifs_assert(inode_is_locked(new_inode)); |
1003 | 1003 | ||
1004 | 1004 | ||
1005 | if (unlink && is_dir) { | 1005 | if (unlink && is_dir) { |
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index eff62801acbf..065c88f8e4b8 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c | |||
@@ -1317,7 +1317,7 @@ int ubifs_fsync(struct file *file, loff_t start, loff_t end, int datasync) | |||
1317 | err = filemap_write_and_wait_range(inode->i_mapping, start, end); | 1317 | err = filemap_write_and_wait_range(inode->i_mapping, start, end); |
1318 | if (err) | 1318 | if (err) |
1319 | return err; | 1319 | return err; |
1320 | mutex_lock(&inode->i_mutex); | 1320 | inode_lock(inode); |
1321 | 1321 | ||
1322 | /* Synchronize the inode unless this is a 'datasync()' call. */ | 1322 | /* Synchronize the inode unless this is a 'datasync()' call. */ |
1323 | if (!datasync || (inode->i_state & I_DIRTY_DATASYNC)) { | 1323 | if (!datasync || (inode->i_state & I_DIRTY_DATASYNC)) { |
@@ -1332,7 +1332,7 @@ int ubifs_fsync(struct file *file, loff_t start, loff_t end, int datasync) | |||
1332 | */ | 1332 | */ |
1333 | err = ubifs_sync_wbufs_by_inode(c, inode); | 1333 | err = ubifs_sync_wbufs_by_inode(c, inode); |
1334 | out: | 1334 | out: |
1335 | mutex_unlock(&inode->i_mutex); | 1335 | inode_unlock(inode); |
1336 | return err; | 1336 | return err; |
1337 | } | 1337 | } |
1338 | 1338 | ||
diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c index e53292d0c21b..c7f4d434d098 100644 --- a/fs/ubifs/xattr.c +++ b/fs/ubifs/xattr.c | |||
@@ -313,7 +313,7 @@ static int setxattr(struct inode *host, const char *name, const void *value, | |||
313 | union ubifs_key key; | 313 | union ubifs_key key; |
314 | int err, type; | 314 | int err, type; |
315 | 315 | ||
316 | ubifs_assert(mutex_is_locked(&host->i_mutex)); | 316 | ubifs_assert(inode_is_locked(host)); |
317 | 317 | ||
318 | if (size > UBIFS_MAX_INO_DATA) | 318 | if (size > UBIFS_MAX_INO_DATA) |
319 | return -ERANGE; | 319 | return -ERANGE; |
@@ -550,7 +550,7 @@ int ubifs_removexattr(struct dentry *dentry, const char *name) | |||
550 | 550 | ||
551 | dbg_gen("xattr '%s', ino %lu ('%pd')", name, | 551 | dbg_gen("xattr '%s', ino %lu ('%pd')", name, |
552 | host->i_ino, dentry); | 552 | host->i_ino, dentry); |
553 | ubifs_assert(mutex_is_locked(&host->i_mutex)); | 553 | ubifs_assert(inode_is_locked(host)); |
554 | 554 | ||
555 | err = check_namespace(&nm); | 555 | err = check_namespace(&nm); |
556 | if (err < 0) | 556 | if (err < 0) |