vfs: create a generic checking and prep function for FS_IOC_SETFLAGS

Create a generic function to check incoming FS_IOC_SETFLAGS flag values
and later prepare the inode for updates so that we can standardize the
implementations that follow ext4's flag values.

Note that the efivarfs implementation no longer fails a no-op SETFLAGS
without CAP_LINUX_IMMUTABLE since that's the behavior in ext*.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: David Sterba <dsterba@suse.com>
Reviewed-by: Bob Peterson <rpeterso@redhat.com>

1 files changed, 3 insertions, 10 deletions

diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index 994726ada857..d6f7b299eb23 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -106,16 +106,9 @@ static int ocfs2_set_inode_attr(struct inode *inode, unsigned flags,
         flags = flags & mask;
         flags |= oldflags & ~mask;
 
-        /*
-         * The IMMUTABLE and APPEND_ONLY flags can only be changed by
-         * the relevant capability.
-         */
-        status = -EPERM;
-        if ((oldflags & OCFS2_IMMUTABLE_FL) || ((flags ^ oldflags) &
-                (OCFS2_APPEND_FL | OCFS2_IMMUTABLE_FL))) {
-                if (!capable(CAP_LINUX_IMMUTABLE))
-                        goto bail_unlock;
-        }
+        status = vfs_ioc_setflags_prepare(inode, oldflags, flags);
+        if (status)
+                goto bail_unlock;
 
         handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
         if (IS_ERR(handle)) {