aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfsd/netns.h
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2019-05-17 16:22:18 -0400
committerJ. Bruce Fields <bfields@redhat.com>2019-07-03 17:52:08 -0400
commit22a46eb44016eec3384da3731a2d47a5d3c91955 (patch)
tree2e66a07b68adede510fe29e105d714b4a43bf6ec /fs/nfsd/netns.h
parent3ba75830ce175550ef45c6524ec62faab8f62c1b (diff)
nfsd: note inadequate stats locking
After 89a26b3d295d "nfsd: split DRC global spinlock into per-bucket locks", there is no longer a single global spinlock to protect these stats. So, really we need to fix that. For now, at least fix the comment. Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/netns.h')
-rw-r--r--fs/nfsd/netns.h7
1 files changed, 5 insertions, 2 deletions
diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h
index 46240c4d9184..ceb413f8fff3 100644
--- a/fs/nfsd/netns.h
+++ b/fs/nfsd/netns.h
@@ -142,8 +142,11 @@ struct nfsd_net {
142 unsigned int drc_hashsize; 142 unsigned int drc_hashsize;
143 143
144 /* 144 /*
145 * Stats and other tracking of on the duplicate reply cache. All of these and 145 * Stats and other tracking of on the duplicate reply cache.
146 * the "rc" fields in nfsdstats are protected by the cache_lock 146 * These fields and the "rc" fields in nfsdstats are modified
147 * with only the per-bucket cache lock, which isn't really safe
148 * and should be fixed if we want the statistics to be
149 * completely accurate.
147 */ 150 */
148 151
149 /* total number of entries */ 152 /* total number of entries */