NFSv4: Report the error from nfs4_select_rw_stateid()

In pnfs_update_layout() ensure that we do report any fatal errors from
nfs4_select_rw_stateid().

Fixes: d9aba2b40de6 ("NFSv4: Don't use the zero stateid with layoutget")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

1 files changed, 1 insertions, 6 deletions

diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 75bd5b552ba4..4525d5acae38 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1903,12 +1903,6 @@ lookup_again:
                 goto out_unlock;
         }
 
-        if (!nfs4_valid_open_stateid(ctx->state)) {
-                trace_pnfs_update_layout(ino, pos, count, iomode, lo, lseg,
-                                PNFS_UPDATE_LAYOUT_INVALID_OPEN);
-                goto out_unlock;
-        }
-
         /*
          * Choose a stateid for the LAYOUTGET. If we don't have a layout
          * stateid, or it has been invalidated, then we must use the open
@@ -1939,6 +1933,7 @@ lookup_again:
                                         iomode == IOMODE_RW ? FMODE_WRITE : FMODE_READ,
                                         NULL, &stateid, NULL);
                 if (status != 0) {
+                        lseg = ERR_PTR(status);
                         trace_pnfs_update_layout(ino, pos, count,
                                         iomode, lo, lseg,
                                         PNFS_UPDATE_LAYOUT_INVALID_OPEN);