diff options
author | Trond Myklebust <trond.myklebust@hammerspace.com> | 2019-02-18 11:35:54 -0500 |
---|---|---|
committer | Trond Myklebust <trond.myklebust@hammerspace.com> | 2019-02-20 15:14:20 -0500 |
commit | 078b5fd92c4913dd367361db6c28568386077c89 (patch) | |
tree | 050fdb065ff9ae968b9cfad355ab3213874da44d /fs/nfs/direct.c | |
parent | 8127d82705998568b52ac724e28e00941538083d (diff) |
NFS: Clean up list moves of struct nfs_page
In several places we're just moving the struct nfs_page from one list to
another by first removing from the existing list, then adding to the new
one.
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'fs/nfs/direct.c')
-rw-r--r-- | fs/nfs/direct.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index 33824a0a57bf..1377ee20ecf9 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c | |||
@@ -664,8 +664,7 @@ static void nfs_direct_write_reschedule(struct nfs_direct_req *dreq) | |||
664 | 664 | ||
665 | list_for_each_entry_safe(req, tmp, &reqs, wb_list) { | 665 | list_for_each_entry_safe(req, tmp, &reqs, wb_list) { |
666 | if (!nfs_pageio_add_request(&desc, req)) { | 666 | if (!nfs_pageio_add_request(&desc, req)) { |
667 | nfs_list_remove_request(req); | 667 | nfs_list_move_request(req, &failed); |
668 | nfs_list_add_request(req, &failed); | ||
669 | spin_lock(&cinfo.inode->i_lock); | 668 | spin_lock(&cinfo.inode->i_lock); |
670 | dreq->flags = 0; | 669 | dreq->flags = 0; |
671 | if (desc.pg_error < 0) | 670 | if (desc.pg_error < 0) |