diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2017-09-14 21:54:01 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-09-14 21:54:01 -0400 |
commit | 0f0d12728e56c94d3289c6831243b6faeae8a19d (patch) | |
tree | bd52fd4ed6fba2a0d8bb95e7fc33f51ac299001d /fs/jffs2 | |
parent | 581bfce969cbfc7ce43ee92273be9cb7c3fdfa61 (diff) | |
parent | e462ec50cb5fad19f6003a3d8087f4a0945dd2b1 (diff) |
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull mount flag updates from Al Viro:
"Another chunk of fmount preparations from dhowells; only trivial
conflicts for that part. It separates MS_... bits (very grotty
mount(2) ABI) from the struct super_block ->s_flags (kernel-internal,
only a small subset of MS_... stuff).
This does *not* convert the filesystems to new constants; only the
infrastructure is done here. The next step in that series is where the
conflicts would be; that's the conversion of filesystems. It's purely
mechanical and it's better done after the merge, so if you could run
something like
list=$(for i in MS_RDONLY MS_NOSUID MS_NODEV MS_NOEXEC MS_SYNCHRONOUS MS_MANDLOCK MS_DIRSYNC MS_NOATIME MS_NODIRATIME MS_SILENT MS_POSIXACL MS_KERNMOUNT MS_I_VERSION MS_LAZYTIME; do git grep -l $i fs drivers/staging/lustre drivers/mtd ipc mm include/linux; done|sort|uniq|grep -v '^fs/namespace.c$')
sed -i -e 's/\<MS_RDONLY\>/SB_RDONLY/g' \
-e 's/\<MS_NOSUID\>/SB_NOSUID/g' \
-e 's/\<MS_NODEV\>/SB_NODEV/g' \
-e 's/\<MS_NOEXEC\>/SB_NOEXEC/g' \
-e 's/\<MS_SYNCHRONOUS\>/SB_SYNCHRONOUS/g' \
-e 's/\<MS_MANDLOCK\>/SB_MANDLOCK/g' \
-e 's/\<MS_DIRSYNC\>/SB_DIRSYNC/g' \
-e 's/\<MS_NOATIME\>/SB_NOATIME/g' \
-e 's/\<MS_NODIRATIME\>/SB_NODIRATIME/g' \
-e 's/\<MS_SILENT\>/SB_SILENT/g' \
-e 's/\<MS_POSIXACL\>/SB_POSIXACL/g' \
-e 's/\<MS_KERNMOUNT\>/SB_KERNMOUNT/g' \
-e 's/\<MS_I_VERSION\>/SB_I_VERSION/g' \
-e 's/\<MS_LAZYTIME\>/SB_LAZYTIME/g' \
$list
and commit it with something along the lines of 'convert filesystems
away from use of MS_... constants' as commit message, it would save a
quite a bit of headache next cycle"
* 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
VFS: Differentiate mount flags (MS_*) from internal superblock flags
VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)
vfs: Add sb_rdonly(sb) to query the MS_RDONLY flag on s_flags
Diffstat (limited to 'fs/jffs2')
-rw-r--r-- | fs/jffs2/fs.c | 6 | ||||
-rw-r--r-- | fs/jffs2/super.c | 2 | ||||
-rw-r--r-- | fs/jffs2/wbuf.c | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c index 76fa814df3d1..e96c6b05e43e 100644 --- a/fs/jffs2/fs.c +++ b/fs/jffs2/fs.c | |||
@@ -395,14 +395,14 @@ int jffs2_do_remount_fs(struct super_block *sb, int *flags, char *data) | |||
395 | { | 395 | { |
396 | struct jffs2_sb_info *c = JFFS2_SB_INFO(sb); | 396 | struct jffs2_sb_info *c = JFFS2_SB_INFO(sb); |
397 | 397 | ||
398 | if (c->flags & JFFS2_SB_FLAG_RO && !(sb->s_flags & MS_RDONLY)) | 398 | if (c->flags & JFFS2_SB_FLAG_RO && !sb_rdonly(sb)) |
399 | return -EROFS; | 399 | return -EROFS; |
400 | 400 | ||
401 | /* We stop if it was running, then restart if it needs to. | 401 | /* We stop if it was running, then restart if it needs to. |
402 | This also catches the case where it was stopped and this | 402 | This also catches the case where it was stopped and this |
403 | is just a remount to restart it. | 403 | is just a remount to restart it. |
404 | Flush the writebuffer, if neccecary, else we loose it */ | 404 | Flush the writebuffer, if neccecary, else we loose it */ |
405 | if (!(sb->s_flags & MS_RDONLY)) { | 405 | if (!sb_rdonly(sb)) { |
406 | jffs2_stop_garbage_collect_thread(c); | 406 | jffs2_stop_garbage_collect_thread(c); |
407 | mutex_lock(&c->alloc_sem); | 407 | mutex_lock(&c->alloc_sem); |
408 | jffs2_flush_wbuf_pad(c); | 408 | jffs2_flush_wbuf_pad(c); |
@@ -590,7 +590,7 @@ int jffs2_do_fill_super(struct super_block *sb, void *data, int silent) | |||
590 | sb->s_blocksize = PAGE_SIZE; | 590 | sb->s_blocksize = PAGE_SIZE; |
591 | sb->s_blocksize_bits = PAGE_SHIFT; | 591 | sb->s_blocksize_bits = PAGE_SHIFT; |
592 | sb->s_magic = JFFS2_SUPER_MAGIC; | 592 | sb->s_magic = JFFS2_SUPER_MAGIC; |
593 | if (!(sb->s_flags & MS_RDONLY)) | 593 | if (!sb_rdonly(sb)) |
594 | jffs2_start_garbage_collect_thread(c); | 594 | jffs2_start_garbage_collect_thread(c); |
595 | return 0; | 595 | return 0; |
596 | 596 | ||
diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c index 5ef21f4c4c77..153f1c6eb169 100644 --- a/fs/jffs2/super.c +++ b/fs/jffs2/super.c | |||
@@ -342,7 +342,7 @@ static void jffs2_put_super (struct super_block *sb) | |||
342 | static void jffs2_kill_sb(struct super_block *sb) | 342 | static void jffs2_kill_sb(struct super_block *sb) |
343 | { | 343 | { |
344 | struct jffs2_sb_info *c = JFFS2_SB_INFO(sb); | 344 | struct jffs2_sb_info *c = JFFS2_SB_INFO(sb); |
345 | if (!(sb->s_flags & MS_RDONLY)) | 345 | if (!sb_rdonly(sb)) |
346 | jffs2_stop_garbage_collect_thread(c); | 346 | jffs2_stop_garbage_collect_thread(c); |
347 | kill_mtd_super(sb); | 347 | kill_mtd_super(sb); |
348 | kfree(c); | 348 | kfree(c); |
diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c index 48d9522e209c..2cfe487708e0 100644 --- a/fs/jffs2/wbuf.c +++ b/fs/jffs2/wbuf.c | |||
@@ -1162,7 +1162,7 @@ static void delayed_wbuf_sync(struct work_struct *work) | |||
1162 | struct jffs2_sb_info *c = work_to_sb(work); | 1162 | struct jffs2_sb_info *c = work_to_sb(work); |
1163 | struct super_block *sb = OFNI_BS_2SFFJ(c); | 1163 | struct super_block *sb = OFNI_BS_2SFFJ(c); |
1164 | 1164 | ||
1165 | if (!(sb->s_flags & MS_RDONLY)) { | 1165 | if (!sb_rdonly(sb)) { |
1166 | jffs2_dbg(1, "%s()\n", __func__); | 1166 | jffs2_dbg(1, "%s()\n", __func__); |
1167 | jffs2_flush_wbuf_gc(c, 0); | 1167 | jffs2_flush_wbuf_gc(c, 0); |
1168 | } | 1168 | } |
@@ -1173,7 +1173,7 @@ void jffs2_dirty_trigger(struct jffs2_sb_info *c) | |||
1173 | struct super_block *sb = OFNI_BS_2SFFJ(c); | 1173 | struct super_block *sb = OFNI_BS_2SFFJ(c); |
1174 | unsigned long delay; | 1174 | unsigned long delay; |
1175 | 1175 | ||
1176 | if (sb->s_flags & MS_RDONLY) | 1176 | if (sb_rdonly(sb)) |
1177 | return; | 1177 | return; |
1178 | 1178 | ||
1179 | delay = msecs_to_jiffies(dirty_writeback_interval * 10); | 1179 | delay = msecs_to_jiffies(dirty_writeback_interval * 10); |