aboutsummaryrefslogtreecommitdiffstats
path: root/fs/gfs2/quota.c
diff options
context:
space:
mode:
authorKirill A. Shutemov <kirill.shutemov@linux.intel.com>2016-04-01 08:29:47 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2016-04-04 13:41:08 -0400
commit09cbfeaf1a5a67bfb3201e0c83c810cecb2efa5a (patch)
tree6cdf210c9c0f981cd22544feeba701892ec19464 /fs/gfs2/quota.c
parentc05c2ec96bb8b7310da1055c7b9d786a3ec6dc0c (diff)
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time ago with promise that one day it will be possible to implement page cache with bigger chunks than PAGE_SIZE. This promise never materialized. And unlikely will. We have many places where PAGE_CACHE_SIZE assumed to be equal to PAGE_SIZE. And it's constant source of confusion on whether PAGE_CACHE_* or PAGE_* constant should be used in a particular case, especially on the border between fs and mm. Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much breakage to be doable. Let's stop pretending that pages in page cache are special. They are not. The changes are pretty straight-forward: - <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>; - <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>; - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN}; - page_cache_get() -> get_page(); - page_cache_release() -> put_page(); This patch contains automated changes generated with coccinelle using script below. For some reason, coccinelle doesn't patch header files. I've called spatch for them manually. The only adjustment after coccinelle is revert of changes to PAGE_CAHCE_ALIGN definition: we are going to drop it later. There are few places in the code where coccinelle didn't reach. I'll fix them manually in a separate patch. Comments and documentation also will be addressed with the separate patch. virtual patch @@ expression E; @@ - E << (PAGE_CACHE_SHIFT - PAGE_SHIFT) + E @@ expression E; @@ - E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) + E @@ @@ - PAGE_CACHE_SHIFT + PAGE_SHIFT @@ @@ - PAGE_CACHE_SIZE + PAGE_SIZE @@ @@ - PAGE_CACHE_MASK + PAGE_MASK @@ expression E; @@ - PAGE_CACHE_ALIGN(E) + PAGE_ALIGN(E) @@ expression E; @@ - page_cache_get(E) + get_page(E) @@ expression E; @@ - page_cache_release(E) + put_page(E) Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Acked-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/gfs2/quota.c')
-rw-r--r--fs/gfs2/quota.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index a39891344259..ce7d69a2fdc0 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -701,7 +701,7 @@ static int gfs2_write_buf_to_page(struct gfs2_inode *ip, unsigned long index,
701 unsigned to_write = bytes, pg_off = off; 701 unsigned to_write = bytes, pg_off = off;
702 int done = 0; 702 int done = 0;
703 703
704 blk = index << (PAGE_CACHE_SHIFT - sdp->sd_sb.sb_bsize_shift); 704 blk = index << (PAGE_SHIFT - sdp->sd_sb.sb_bsize_shift);
705 boff = off % bsize; 705 boff = off % bsize;
706 706
707 page = find_or_create_page(mapping, index, GFP_NOFS); 707 page = find_or_create_page(mapping, index, GFP_NOFS);
@@ -753,13 +753,13 @@ static int gfs2_write_buf_to_page(struct gfs2_inode *ip, unsigned long index,
753 flush_dcache_page(page); 753 flush_dcache_page(page);
754 kunmap_atomic(kaddr); 754 kunmap_atomic(kaddr);
755 unlock_page(page); 755 unlock_page(page);
756 page_cache_release(page); 756 put_page(page);
757 757
758 return 0; 758 return 0;
759 759
760unlock_out: 760unlock_out:
761 unlock_page(page); 761 unlock_page(page);
762 page_cache_release(page); 762 put_page(page);
763 return -EIO; 763 return -EIO;
764} 764}
765 765
@@ -773,13 +773,13 @@ static int gfs2_write_disk_quota(struct gfs2_inode *ip, struct gfs2_quota *qp,
773 773
774 nbytes = sizeof(struct gfs2_quota); 774 nbytes = sizeof(struct gfs2_quota);
775 775
776 pg_beg = loc >> PAGE_CACHE_SHIFT; 776 pg_beg = loc >> PAGE_SHIFT;
777 pg_off = loc % PAGE_CACHE_SIZE; 777 pg_off = loc % PAGE_SIZE;
778 778
779 /* If the quota straddles a page boundary, split the write in two */ 779 /* If the quota straddles a page boundary, split the write in two */
780 if ((pg_off + nbytes) > PAGE_CACHE_SIZE) { 780 if ((pg_off + nbytes) > PAGE_SIZE) {
781 pg_oflow = 1; 781 pg_oflow = 1;
782 overflow = (pg_off + nbytes) - PAGE_CACHE_SIZE; 782 overflow = (pg_off + nbytes) - PAGE_SIZE;
783 } 783 }
784 784
785 ptr = qp; 785 ptr = qp;