diff options
author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2019-07-25 23:45:12 -0400 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2019-08-23 10:57:12 -0400 |
commit | 280fd422958187ac5f069c08d84dd65f7f87c2e6 (patch) | |
tree | 2011a247bfc2e817968de1f3efdc26676f8e327f /fs/f2fs/debug.c | |
parent | 038d06984f5c50a101c1cf47bc6419064042716d (diff) |
fs: f2fs: Remove unnecessary checks of SM_I(sbi) in update_general_status()
In fill_super() and put_super(), f2fs_destroy_stats() is called
in prior to f2fs_destroy_segment_manager(), so if current
sbi can still be visited in global stat list, SM_I(sbi) should be
released yet.
For this reason, SM_I(sbi) does not need to be checked in
update_general_status().
Thank Chao Yu for advice.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/debug.c')
-rw-r--r-- | fs/f2fs/debug.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index 7706049d23bf..9b0bedd82581 100644 --- a/fs/f2fs/debug.c +++ b/fs/f2fs/debug.c | |||
@@ -67,7 +67,7 @@ static void update_general_status(struct f2fs_sb_info *sbi) | |||
67 | si->nr_rd_data = get_pages(sbi, F2FS_RD_DATA); | 67 | si->nr_rd_data = get_pages(sbi, F2FS_RD_DATA); |
68 | si->nr_rd_node = get_pages(sbi, F2FS_RD_NODE); | 68 | si->nr_rd_node = get_pages(sbi, F2FS_RD_NODE); |
69 | si->nr_rd_meta = get_pages(sbi, F2FS_RD_META); | 69 | si->nr_rd_meta = get_pages(sbi, F2FS_RD_META); |
70 | if (SM_I(sbi) && SM_I(sbi)->fcc_info) { | 70 | if (SM_I(sbi)->fcc_info) { |
71 | si->nr_flushed = | 71 | si->nr_flushed = |
72 | atomic_read(&SM_I(sbi)->fcc_info->issued_flush); | 72 | atomic_read(&SM_I(sbi)->fcc_info->issued_flush); |
73 | si->nr_flushing = | 73 | si->nr_flushing = |
@@ -75,7 +75,7 @@ static void update_general_status(struct f2fs_sb_info *sbi) | |||
75 | si->flush_list_empty = | 75 | si->flush_list_empty = |
76 | llist_empty(&SM_I(sbi)->fcc_info->issue_list); | 76 | llist_empty(&SM_I(sbi)->fcc_info->issue_list); |
77 | } | 77 | } |
78 | if (SM_I(sbi) && SM_I(sbi)->dcc_info) { | 78 | if (SM_I(sbi)->dcc_info) { |
79 | si->nr_discarded = | 79 | si->nr_discarded = |
80 | atomic_read(&SM_I(sbi)->dcc_info->issued_discard); | 80 | atomic_read(&SM_I(sbi)->dcc_info->issued_discard); |
81 | si->nr_discarding = | 81 | si->nr_discarding = |