diff options
author | zhengbin <zhengbin13@huawei.com> | 2019-02-01 06:19:15 -0500 |
---|---|---|
committer | Ilya Dryomov <idryomov@gmail.com> | 2019-03-05 12:55:17 -0500 |
commit | e450f4d1a5d633d60a7384b54dea3c89037d41b1 (patch) | |
tree | 2d4ec6a2955aef0d844ae59249d91080fbd0d67d /fs/ceph | |
parent | 0c93e1b7a26b418247218d08a6d0b95d61c9c415 (diff) |
ceph: pass inclusive lend parameter to filemap_write_and_wait_range()
The 'lend' parameter of filemap_write_and_wait_range is required to be
inclusive, so follow the rule. Same for invalidate_inode_pages2_range.
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs/ceph')
-rw-r--r-- | fs/ceph/file.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 189df668b6a0..9f53c3d99304 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c | |||
@@ -590,7 +590,8 @@ static ssize_t ceph_sync_read(struct kiocb *iocb, struct iov_iter *to, | |||
590 | * but it will at least behave sensibly when they are | 590 | * but it will at least behave sensibly when they are |
591 | * in sequence. | 591 | * in sequence. |
592 | */ | 592 | */ |
593 | ret = filemap_write_and_wait_range(inode->i_mapping, off, off + len); | 593 | ret = filemap_write_and_wait_range(inode->i_mapping, |
594 | off, off + len - 1); | ||
594 | if (ret < 0) | 595 | if (ret < 0) |
595 | return ret; | 596 | return ret; |
596 | 597 | ||
@@ -929,14 +930,15 @@ ceph_direct_read_write(struct kiocb *iocb, struct iov_iter *iter, | |||
929 | (write ? "write" : "read"), file, pos, (unsigned)count, | 930 | (write ? "write" : "read"), file, pos, (unsigned)count, |
930 | snapc, snapc->seq); | 931 | snapc, snapc->seq); |
931 | 932 | ||
932 | ret = filemap_write_and_wait_range(inode->i_mapping, pos, pos + count); | 933 | ret = filemap_write_and_wait_range(inode->i_mapping, |
934 | pos, pos + count - 1); | ||
933 | if (ret < 0) | 935 | if (ret < 0) |
934 | return ret; | 936 | return ret; |
935 | 937 | ||
936 | if (write) { | 938 | if (write) { |
937 | int ret2 = invalidate_inode_pages2_range(inode->i_mapping, | 939 | int ret2 = invalidate_inode_pages2_range(inode->i_mapping, |
938 | pos >> PAGE_SHIFT, | 940 | pos >> PAGE_SHIFT, |
939 | (pos + count) >> PAGE_SHIFT); | 941 | (pos + count - 1) >> PAGE_SHIFT); |
940 | if (ret2 < 0) | 942 | if (ret2 < 0) |
941 | dout("invalidate_inode_pages2_range returned %d\n", ret2); | 943 | dout("invalidate_inode_pages2_range returned %d\n", ret2); |
942 | 944 | ||
@@ -1132,13 +1134,14 @@ ceph_sync_write(struct kiocb *iocb, struct iov_iter *from, loff_t pos, | |||
1132 | dout("sync_write on file %p %lld~%u snapc %p seq %lld\n", | 1134 | dout("sync_write on file %p %lld~%u snapc %p seq %lld\n", |
1133 | file, pos, (unsigned)count, snapc, snapc->seq); | 1135 | file, pos, (unsigned)count, snapc, snapc->seq); |
1134 | 1136 | ||
1135 | ret = filemap_write_and_wait_range(inode->i_mapping, pos, pos + count); | 1137 | ret = filemap_write_and_wait_range(inode->i_mapping, |
1138 | pos, pos + count - 1); | ||
1136 | if (ret < 0) | 1139 | if (ret < 0) |
1137 | return ret; | 1140 | return ret; |
1138 | 1141 | ||
1139 | ret = invalidate_inode_pages2_range(inode->i_mapping, | 1142 | ret = invalidate_inode_pages2_range(inode->i_mapping, |
1140 | pos >> PAGE_SHIFT, | 1143 | pos >> PAGE_SHIFT, |
1141 | (pos + count) >> PAGE_SHIFT); | 1144 | (pos + count - 1) >> PAGE_SHIFT); |
1142 | if (ret < 0) | 1145 | if (ret < 0) |
1143 | dout("invalidate_inode_pages2_range returned %d\n", ret); | 1146 | dout("invalidate_inode_pages2_range returned %d\n", ret); |
1144 | 1147 | ||