afs: Fix server rotation's handling of fileserver probe failure

The server rotation algorithm just gives up if it fails to probe a
fileserver.  Fix this by rotating to the next fileserver instead.

Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
Signed-off-by: David Howells <dhowells@redhat.com>

1 files changed, 10 insertions, 2 deletions

diff --git a/fs/afs/rotate.c b/fs/afs/rotate.c
index 4a26d51b2968..84584dcced72 100644
--- a/fs/afs/rotate.c
+++ b/fs/afs/rotate.c
@@ -369,8 +369,16 @@ use_server:
         if (!test_bit(AFS_SERVER_FL_PROBED, &server->flags)) {
                 fc->ac.alist = afs_get_addrlist(alist);
 
-                if (!afs_probe_fileserver(fc))
-                        goto failed;
+                if (!afs_probe_fileserver(fc)) {
+                        switch (fc->ac.error) {
+                        case -ENOMEM:
+                        case -ERESTARTSYS:
+                        case -EINTR:
+                                goto failed;
+                        default:
+                                goto next_server;
+                        }
+                }
         }
 
         if (!fc->ac.alist)