diff options
author | Fabian Frederick <fabf@skynet.be> | 2015-02-17 16:46:23 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-02-17 17:34:52 -0500 |
commit | f157853e407c0611cd6acbc400fa6c7be420b1bd (patch) | |
tree | c8ee0adacfd4b798228d0ccd65de3f3ec0ce24d5 /fs/affs/namei.c | |
parent | eeb36f8e938d151fc5e12e96ae13d0e283be357e (diff) |
fs/affs: define AFFSNAMEMAX to replace constant use
30 was used all over the place to compare name length against
AFFS maximum name length.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/affs/namei.c')
-rw-r--r-- | fs/affs/namei.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/fs/affs/namei.c b/fs/affs/namei.c index 66c6cb349bf6..ffb7bd82c2a5 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c | |||
@@ -72,7 +72,7 @@ __affs_hash_dentry(struct qstr *qstr, toupper_t toupper, bool notruncate) | |||
72 | return retval; | 72 | return retval; |
73 | 73 | ||
74 | hash = init_name_hash(); | 74 | hash = init_name_hash(); |
75 | len = min(qstr->len, 30u); | 75 | len = min(qstr->len, AFFSNAMEMAX); |
76 | for (; len > 0; name++, len--) | 76 | for (; len > 0; name++, len--) |
77 | hash = partial_name_hash(toupper(*name), hash); | 77 | hash = partial_name_hash(toupper(*name), hash); |
78 | qstr->hash = end_name_hash(hash); | 78 | qstr->hash = end_name_hash(hash); |
@@ -115,10 +115,10 @@ static inline int __affs_compare_dentry(unsigned int len, | |||
115 | * If the names are longer than the allowed 30 chars, | 115 | * If the names are longer than the allowed 30 chars, |
116 | * the excess is ignored, so their length may differ. | 116 | * the excess is ignored, so their length may differ. |
117 | */ | 117 | */ |
118 | if (len >= 30) { | 118 | if (len >= AFFSNAMEMAX) { |
119 | if (name->len < 30) | 119 | if (name->len < AFFSNAMEMAX) |
120 | return 1; | 120 | return 1; |
121 | len = 30; | 121 | len = AFFSNAMEMAX; |
122 | } else if (len != name->len) | 122 | } else if (len != name->len) |
123 | return 1; | 123 | return 1; |
124 | 124 | ||
@@ -157,10 +157,10 @@ affs_match(struct dentry *dentry, const u8 *name2, toupper_t toupper) | |||
157 | const u8 *name = dentry->d_name.name; | 157 | const u8 *name = dentry->d_name.name; |
158 | int len = dentry->d_name.len; | 158 | int len = dentry->d_name.len; |
159 | 159 | ||
160 | if (len >= 30) { | 160 | if (len >= AFFSNAMEMAX) { |
161 | if (*name2 < 30) | 161 | if (*name2 < AFFSNAMEMAX) |
162 | return 0; | 162 | return 0; |
163 | len = 30; | 163 | len = AFFSNAMEMAX; |
164 | } else if (len != *name2) | 164 | } else if (len != *name2) |
165 | return 0; | 165 | return 0; |
166 | 166 | ||
@@ -176,7 +176,7 @@ affs_hash_name(struct super_block *sb, const u8 *name, unsigned int len) | |||
176 | toupper_t toupper = affs_get_toupper(sb); | 176 | toupper_t toupper = affs_get_toupper(sb); |
177 | u32 hash; | 177 | u32 hash; |
178 | 178 | ||
179 | hash = len = min(len, 30u); | 179 | hash = len = min(len, AFFSNAMEMAX); |
180 | for (; len > 0; len--) | 180 | for (; len > 0; len--) |
181 | hash = (hash * 13 + toupper(*name++)) & 0x7ff; | 181 | hash = (hash * 13 + toupper(*name++)) & 0x7ff; |
182 | 182 | ||