scsi: core: check for equality of result byte values

When evaluating a SCSI command's result using the field access macros,
check for equality of the fields and not if a specific bit is set.

This is a preparation patch, for reworking the results field in the
SCSI command.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

1 files changed, 2 insertions, 3 deletions

diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 60ef8df42b95..1ed2cd82129d 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -3473,9 +3473,8 @@ static void srb_done(struct AdapterCtlBlk *acb, struct DeviceCtlBlk *dcb,
 
         /*if( srb->cmd->cmnd[0] == INQUIRY && */
         /*  (host_byte(cmd->result) == DID_OK || status_byte(cmd->result) & CHECK_CONDITION) ) */
-                if ((cmd->result == (DID_OK << 16)
-                     || status_byte(cmd->result) &
-                     CHECK_CONDITION)) {
+                if ((cmd->result == (DID_OK << 16) ||
+                     status_byte(cmd->result) == CHECK_CONDITION)) {
                         if (!dcb->init_tcq_flag) {
                                 add_dev(acb, dcb, ptr);
                                 dcb->init_tcq_flag = 1;