aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pci/controller/vmd.c
diff options
context:
space:
mode:
authorJon Derrick <jonathan.derrick@intel.com>2019-09-16 09:54:35 -0400
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>2019-09-17 12:40:18 -0400
commita1a30170138c9c5157bd514ccd4d76b47060f29b (patch)
tree554a6bea3e7c12796bd94d9e8880c3dcdf5ac306 /drivers/pci/controller/vmd.c
parente3dffa4f6c3612dea337c9c59191bd418afc941b (diff)
PCI: vmd: Fix shadow offsets to reflect spec changes
The shadow offset scratchpad was moved to 0x2000-0x2010. Update the location to get the correct shadow offset. Fixes: 6788958e4f3c ("PCI: vmd: Assign membar addresses from shadow registers") Signed-off-by: Jon Derrick <jonathan.derrick@intel.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: stable@vger.kernel.org # v5.2+
Diffstat (limited to 'drivers/pci/controller/vmd.c')
-rw-r--r--drivers/pci/controller/vmd.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 2e4da3f51d6b..a35d3f3996d7 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -31,6 +31,9 @@
31#define PCI_REG_VMLOCK 0x70 31#define PCI_REG_VMLOCK 0x70
32#define MB2_SHADOW_EN(vmlock) (vmlock & 0x2) 32#define MB2_SHADOW_EN(vmlock) (vmlock & 0x2)
33 33
34#define MB2_SHADOW_OFFSET 0x2000
35#define MB2_SHADOW_SIZE 16
36
34enum vmd_features { 37enum vmd_features {
35 /* 38 /*
36 * Device may contain registers which hint the physical location of the 39 * Device may contain registers which hint the physical location of the
@@ -578,7 +581,7 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
578 u32 vmlock; 581 u32 vmlock;
579 int ret; 582 int ret;
580 583
581 membar2_offset = 0x2018; 584 membar2_offset = MB2_SHADOW_OFFSET + MB2_SHADOW_SIZE;
582 ret = pci_read_config_dword(vmd->dev, PCI_REG_VMLOCK, &vmlock); 585 ret = pci_read_config_dword(vmd->dev, PCI_REG_VMLOCK, &vmlock);
583 if (ret || vmlock == ~0) 586 if (ret || vmlock == ~0)
584 return -ENODEV; 587 return -ENODEV;
@@ -590,9 +593,9 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
590 if (!membar2) 593 if (!membar2)
591 return -ENOMEM; 594 return -ENOMEM;
592 offset[0] = vmd->dev->resource[VMD_MEMBAR1].start - 595 offset[0] = vmd->dev->resource[VMD_MEMBAR1].start -
593 readq(membar2 + 0x2008); 596 readq(membar2 + MB2_SHADOW_OFFSET);
594 offset[1] = vmd->dev->resource[VMD_MEMBAR2].start - 597 offset[1] = vmd->dev->resource[VMD_MEMBAR2].start -
595 readq(membar2 + 0x2010); 598 readq(membar2 + MB2_SHADOW_OFFSET + 8);
596 pci_iounmap(vmd->dev, membar2); 599 pci_iounmap(vmd->dev, membar2);
597 } 600 }
598 } 601 }