of: overlay: check prevents multiple fragments touching same property

Add test case of two fragments updating the same property.  After
adding the test case, the system hangs at end of boot, after
after slub stack dumps from kfree() in crypto modprobe code.

Multiple overlay fragments adding, modifying, or deleting the same
property is not supported.  Add check to detect the attempt and fail
the overlay apply.

Before this patch, the first fragment error would terminate
processing.  Allow fragment checking to proceed and report all
of the fragment errors before terminating the overlay apply. This
is not a hot path, thus not a performance issue (the error is not
transient and requires fixing the overlay before attempting to
apply it again).

After applying this patch, the devicetree unittest messages will
include:

   OF: overlay: ERROR: multiple fragments add, update, and/or delete property /testcase-data-2/substation@100/motor-1/rpm_avail

   ...

   ### dt-test ### end of unittest - 212 passed, 0 failed

The check to detect two fragments updating the same property is
folded into the patch that created the test case to maintain
bisectability.

Tested-by: Alan Tull <atull@kernel.org>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>

1 files changed, 5 insertions, 0 deletions

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index f82edf829f43..f0139d1e8b63 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -2162,6 +2162,7 @@ OVERLAY_INFO_EXTERN(overlay_12);
 OVERLAY_INFO_EXTERN(overlay_13);
 OVERLAY_INFO_EXTERN(overlay_15);
 OVERLAY_INFO_EXTERN(overlay_bad_add_dup_node);
+OVERLAY_INFO_EXTERN(overlay_bad_add_dup_prop);
 OVERLAY_INFO_EXTERN(overlay_bad_phandle);
 OVERLAY_INFO_EXTERN(overlay_bad_symbol);
 
@@ -2185,6 +2186,7 @@ static struct overlay_info overlays[] = {
         OVERLAY_INFO(overlay_13, 0),
         OVERLAY_INFO(overlay_15, 0),
         OVERLAY_INFO(overlay_bad_add_dup_node, -EINVAL),
+        OVERLAY_INFO(overlay_bad_add_dup_prop, -EINVAL),
         OVERLAY_INFO(overlay_bad_phandle, -EINVAL),
         OVERLAY_INFO(overlay_bad_symbol, -EINVAL),
         {}
@@ -2435,6 +2437,9 @@ static __init void of_unittest_overlay_high_level(void)
         unittest(overlay_data_apply("overlay_bad_add_dup_node", NULL),
                  "Adding overlay 'overlay_bad_add_dup_node' failed\n");
 
+        unittest(overlay_data_apply("overlay_bad_add_dup_prop", NULL),
+                 "Adding overlay 'overlay_bad_add_dup_prop' failed\n");
+
         unittest(overlay_data_apply("overlay_bad_phandle", NULL),
                  "Adding overlay 'overlay_bad_phandle' failed\n");