aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/pci/ivtv
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-08-22 10:06:32 -0400
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-08-26 13:08:50 -0400
commitcce8ccca80d8388982133192d0a6d9dc2e8ed712 (patch)
tree4e37956f86eba2c619fe2a4d56af0b5c993411ae /drivers/media/pci/ivtv
parent093347abc7a4e0490e3c962ecbde2dc272a8f708 (diff)
media: use the BIT() macro
As warned by cppcheck: [drivers/media/dvb-frontends/cx24123.c:434]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [drivers/media/pci/bt8xx/bttv-input.c:87]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [drivers/media/pci/bt8xx/bttv-input.c:98]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour ... [drivers/media/v4l2-core/v4l2-ioctl.c:1391]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour There are lots of places where we're doing 1 << 31. That's bad, as, depending on the architecture, this has an undefined behavior. The BIT() macro is already prepared to handle this, so, let's just switch all "1 << number" macros by BIT(number) at the header files with has 1 << 31. Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> # exynos4-is and s3c-camif Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # omap3isp, vsp1, xilinx, wl128x and ipu3 Reviewed-by: Benoit Parrot <bparrot@ti.com> # am437x and ti-vpe Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/pci/ivtv')
-rw-r--r--drivers/media/pci/ivtv/ivtv-irq.h28
1 files changed, 14 insertions, 14 deletions
diff --git a/drivers/media/pci/ivtv/ivtv-irq.h b/drivers/media/pci/ivtv/ivtv-irq.h
index 7d2f45e2b83c..b8b0703a1c82 100644
--- a/drivers/media/pci/ivtv/ivtv-irq.h
+++ b/drivers/media/pci/ivtv/ivtv-irq.h
@@ -10,20 +10,20 @@
10#ifndef IVTV_IRQ_H 10#ifndef IVTV_IRQ_H
11#define IVTV_IRQ_H 11#define IVTV_IRQ_H
12 12
13#define IVTV_IRQ_ENC_START_CAP (0x1 << 31) 13#define IVTV_IRQ_ENC_START_CAP BIT(31)
14#define IVTV_IRQ_ENC_EOS (0x1 << 30) 14#define IVTV_IRQ_ENC_EOS BIT(30)
15#define IVTV_IRQ_ENC_VBI_CAP (0x1 << 29) 15#define IVTV_IRQ_ENC_VBI_CAP BIT(29)
16#define IVTV_IRQ_ENC_VIM_RST (0x1 << 28) 16#define IVTV_IRQ_ENC_VIM_RST BIT(28)
17#define IVTV_IRQ_ENC_DMA_COMPLETE (0x1 << 27) 17#define IVTV_IRQ_ENC_DMA_COMPLETE BIT(27)
18#define IVTV_IRQ_ENC_PIO_COMPLETE (0x1 << 25) 18#define IVTV_IRQ_ENC_PIO_COMPLETE BIT(25)
19#define IVTV_IRQ_DEC_AUD_MODE_CHG (0x1 << 24) 19#define IVTV_IRQ_DEC_AUD_MODE_CHG BIT(24)
20#define IVTV_IRQ_DEC_DATA_REQ (0x1 << 22) 20#define IVTV_IRQ_DEC_DATA_REQ BIT(22)
21#define IVTV_IRQ_DEC_DMA_COMPLETE (0x1 << 20) 21#define IVTV_IRQ_DEC_DMA_COMPLETE BIT(20)
22#define IVTV_IRQ_DEC_VBI_RE_INSERT (0x1 << 19) 22#define IVTV_IRQ_DEC_VBI_RE_INSERT BIT(19)
23#define IVTV_IRQ_DMA_ERR (0x1 << 18) 23#define IVTV_IRQ_DMA_ERR BIT(18)
24#define IVTV_IRQ_DMA_WRITE (0x1 << 17) 24#define IVTV_IRQ_DMA_WRITE BIT(17)
25#define IVTV_IRQ_DMA_READ (0x1 << 16) 25#define IVTV_IRQ_DMA_READ BIT(16)
26#define IVTV_IRQ_DEC_VSYNC (0x1 << 10) 26#define IVTV_IRQ_DEC_VSYNC BIT(10)
27 27
28/* IRQ Masks */ 28/* IRQ Masks */
29#define IVTV_IRQ_MASK_INIT (IVTV_IRQ_DMA_ERR|IVTV_IRQ_ENC_DMA_COMPLETE|\ 29#define IVTV_IRQ_MASK_INIT (IVTV_IRQ_DMA_ERR|IVTV_IRQ_ENC_DMA_COMPLETE|\