diff options
author | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2018-03-23 06:52:25 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2018-03-23 06:56:15 -0400 |
commit | 057bad7bc9eec71152be1b7bf1f9c2470b7db8e6 (patch) | |
tree | 6482556e08b8102c46379204f6a5b5ea353df823 /drivers/media/pci/ivtv | |
parent | b1a5dea69e48c3306e47ac470e3ff9f2fc0bbe28 (diff) |
media: ivtvfb: Cleanup some warnings
drivers/media/pci/ivtv/ivtvfb.c:349 ivtvfb_prep_frame() warn: argument 3 to %08lx specifier is cast from pointer
drivers/media/pci/ivtv/ivtvfb.c:360 ivtvfb_prep_frame() warn: argument 3 to %08lx specifier is cast from pointer
drivers/media/pci/ivtv/ivtvfb.c:363 ivtvfb_prep_frame() warn: argument 4 to %08lx specifier is cast from pointer
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/pci/ivtv')
-rw-r--r-- | drivers/media/pci/ivtv/ivtvfb.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c index 621b2f613d81..8e62b8be6529 100644 --- a/drivers/media/pci/ivtv/ivtvfb.c +++ b/drivers/media/pci/ivtv/ivtvfb.c | |||
@@ -346,8 +346,8 @@ static int ivtvfb_prep_frame(struct ivtv *itv, int cmd, void __user *source, | |||
346 | 346 | ||
347 | /* Not fatal, but will have undesirable results */ | 347 | /* Not fatal, but will have undesirable results */ |
348 | if ((unsigned long)source & 3) | 348 | if ((unsigned long)source & 3) |
349 | IVTVFB_WARN("ivtvfb_prep_frame: Source address not 32 bit aligned (0x%08lx)\n", | 349 | IVTVFB_WARN("ivtvfb_prep_frame: Source address not 32 bit aligned (%p)\n", |
350 | (unsigned long)source); | 350 | source); |
351 | 351 | ||
352 | if (dest_offset & 3) | 352 | if (dest_offset & 3) |
353 | IVTVFB_WARN("ivtvfb_prep_frame: Dest offset not 32 bit aligned (%ld)\n", dest_offset); | 353 | IVTVFB_WARN("ivtvfb_prep_frame: Dest offset not 32 bit aligned (%ld)\n", dest_offset); |
@@ -357,12 +357,10 @@ static int ivtvfb_prep_frame(struct ivtv *itv, int cmd, void __user *source, | |||
357 | 357 | ||
358 | /* Check Source */ | 358 | /* Check Source */ |
359 | if (!access_ok(VERIFY_READ, source + dest_offset, count)) { | 359 | if (!access_ok(VERIFY_READ, source + dest_offset, count)) { |
360 | IVTVFB_WARN("Invalid userspace pointer 0x%08lx\n", | 360 | IVTVFB_WARN("Invalid userspace pointer %p\n", source); |
361 | (unsigned long)source); | ||
362 | 361 | ||
363 | IVTVFB_DEBUG_WARN("access_ok() failed for offset 0x%08lx source 0x%08lx count %d\n", | 362 | IVTVFB_DEBUG_WARN("access_ok() failed for offset 0x%08lx source %p count %d\n", |
364 | dest_offset, (unsigned long)source, | 363 | dest_offset, source, count); |
365 | count); | ||
366 | return -EINVAL; | 364 | return -EINVAL; |
367 | } | 365 | } |
368 | 366 | ||