aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md/dm-raid.c
diff options
context:
space:
mode:
authorMike Snitzer <snitzer@redhat.com>2016-06-02 11:58:51 -0400
committerMike Snitzer <snitzer@redhat.com>2016-06-14 17:24:58 -0400
commit3fa6cf38211619f2a1fc9e54b5a19befb464f79a (patch)
tree6e95db41549734f2c85d46120817c58c97615eec /drivers/md/dm-raid.c
parent9b6e54232992a2e39790d93df4581a2dcb8a5429 (diff)
dm raid: rename _argname_by_flag to dm_raid_arg_name_by_flag
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-raid.c')
-rw-r--r--drivers/md/dm-raid.c60
1 files changed, 30 insertions, 30 deletions
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 88738281284a..7876f9529f82 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -328,7 +328,7 @@ static struct arg_name_flag {
328}; 328};
329 329
330/* Return argument name string for given @flag */ 330/* Return argument name string for given @flag */
331static const char *_argname_by_flag(const uint32_t flag) 331static const char *dm_raid_arg_name_by_flag(const uint32_t flag)
332{ 332{
333 if (hweight32(flag) == 1) { 333 if (hweight32(flag) == 1) {
334 struct arg_name_flag *anf = _arg_name_flags + ARRAY_SIZE(_arg_name_flags); 334 struct arg_name_flag *anf = _arg_name_flags + ARRAY_SIZE(_arg_name_flags);
@@ -1060,7 +1060,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1060 return -EINVAL; 1060 return -EINVAL;
1061 } 1061 }
1062 1062
1063 if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_NOSYNC))) { 1063 if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_NOSYNC))) {
1064 if (_test_and_set_flag(CTR_FLAG_NOSYNC, &rs->ctr_flags)) { 1064 if (_test_and_set_flag(CTR_FLAG_NOSYNC, &rs->ctr_flags)) {
1065 rs->ti->error = "Only one 'nosync' argument allowed"; 1065 rs->ti->error = "Only one 'nosync' argument allowed";
1066 return -EINVAL; 1066 return -EINVAL;
@@ -1068,7 +1068,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1068 rs->md.recovery_cp = MaxSector; 1068 rs->md.recovery_cp = MaxSector;
1069 continue; 1069 continue;
1070 } 1070 }
1071 if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_SYNC))) { 1071 if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_SYNC))) {
1072 if (_test_and_set_flag(CTR_FLAG_SYNC, &rs->ctr_flags)) { 1072 if (_test_and_set_flag(CTR_FLAG_SYNC, &rs->ctr_flags)) {
1073 rs->ti->error = "Only one 'sync' argument allowed"; 1073 rs->ti->error = "Only one 'sync' argument allowed";
1074 return -EINVAL; 1074 return -EINVAL;
@@ -1076,7 +1076,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1076 rs->md.recovery_cp = 0; 1076 rs->md.recovery_cp = 0;
1077 continue; 1077 continue;
1078 } 1078 }
1079 if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_RAID10_USE_NEAR_SETS))) { 1079 if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_RAID10_USE_NEAR_SETS))) {
1080 if (_test_and_set_flag(CTR_FLAG_RAID10_USE_NEAR_SETS, &rs->ctr_flags)) { 1080 if (_test_and_set_flag(CTR_FLAG_RAID10_USE_NEAR_SETS, &rs->ctr_flags)) {
1081 rs->ti->error = "Only one 'raid10_use_new_sets' argument allowed"; 1081 rs->ti->error = "Only one 'raid10_use_new_sets' argument allowed";
1082 return -EINVAL; 1082 return -EINVAL;
@@ -1095,7 +1095,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1095 * Parameters that take a string value are checked here. 1095 * Parameters that take a string value are checked here.
1096 */ 1096 */
1097 1097
1098 if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_RAID10_FORMAT))) { 1098 if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_RAID10_FORMAT))) {
1099 if (_test_and_set_flag(CTR_FLAG_RAID10_FORMAT, &rs->ctr_flags)) { 1099 if (_test_and_set_flag(CTR_FLAG_RAID10_FORMAT, &rs->ctr_flags)) {
1100 rs->ti->error = "Only one 'raid10_format' argument pair allowed"; 1100 rs->ti->error = "Only one 'raid10_format' argument pair allowed";
1101 return -EINVAL; 1101 return -EINVAL;
@@ -1117,7 +1117,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1117 return -EINVAL; 1117 return -EINVAL;
1118 } 1118 }
1119 1119
1120 if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_REBUILD))) { 1120 if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_REBUILD))) {
1121 /* 1121 /*
1122 * "rebuild" is being passed in by userspace to provide 1122 * "rebuild" is being passed in by userspace to provide
1123 * indexes of replaced devices and to set up additional 1123 * indexes of replaced devices and to set up additional
@@ -1138,7 +1138,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1138 clear_bit(Faulty, &rd->rdev.flags); 1138 clear_bit(Faulty, &rd->rdev.flags);
1139 rd->rdev.recovery_offset = 0; 1139 rd->rdev.recovery_offset = 0;
1140 _set_flag(CTR_FLAG_REBUILD, &rs->ctr_flags); 1140 _set_flag(CTR_FLAG_REBUILD, &rs->ctr_flags);
1141 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_WRITE_MOSTLY))) { 1141 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_WRITE_MOSTLY))) {
1142 if (!rt_is_raid1(rt)) { 1142 if (!rt_is_raid1(rt)) {
1143 rs->ti->error = "write_mostly option is only valid for RAID1"; 1143 rs->ti->error = "write_mostly option is only valid for RAID1";
1144 return -EINVAL; 1144 return -EINVAL;
@@ -1151,7 +1151,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1151 1151
1152 set_bit(WriteMostly, &rs->dev[value].rdev.flags); 1152 set_bit(WriteMostly, &rs->dev[value].rdev.flags);
1153 _set_flag(CTR_FLAG_WRITE_MOSTLY, &rs->ctr_flags); 1153 _set_flag(CTR_FLAG_WRITE_MOSTLY, &rs->ctr_flags);
1154 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_MAX_WRITE_BEHIND))) { 1154 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_MAX_WRITE_BEHIND))) {
1155 if (!rt_is_raid1(rt)) { 1155 if (!rt_is_raid1(rt)) {
1156 rs->ti->error = "max_write_behind option is only valid for RAID1"; 1156 rs->ti->error = "max_write_behind option is only valid for RAID1";
1157 return -EINVAL; 1157 return -EINVAL;
@@ -1173,7 +1173,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1173 } 1173 }
1174 1174
1175 rs->md.bitmap_info.max_write_behind = value; 1175 rs->md.bitmap_info.max_write_behind = value;
1176 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_DAEMON_SLEEP))) { 1176 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_DAEMON_SLEEP))) {
1177 if (_test_and_set_flag(CTR_FLAG_DAEMON_SLEEP, &rs->ctr_flags)) { 1177 if (_test_and_set_flag(CTR_FLAG_DAEMON_SLEEP, &rs->ctr_flags)) {
1178 rs->ti->error = "Only one daemon_sleep argument pair allowed"; 1178 rs->ti->error = "Only one daemon_sleep argument pair allowed";
1179 return -EINVAL; 1179 return -EINVAL;
@@ -1183,7 +1183,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1183 return -EINVAL; 1183 return -EINVAL;
1184 } 1184 }
1185 rs->md.bitmap_info.daemon_sleep = value; 1185 rs->md.bitmap_info.daemon_sleep = value;
1186 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_DATA_OFFSET))) { 1186 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_DATA_OFFSET))) {
1187 /* Userspace passes new data_offset after having extended the the data image LV */ 1187 /* Userspace passes new data_offset after having extended the the data image LV */
1188 if (_test_and_set_flag(CTR_FLAG_DATA_OFFSET, &rs->ctr_flags)) { 1188 if (_test_and_set_flag(CTR_FLAG_DATA_OFFSET, &rs->ctr_flags)) {
1189 rs->ti->error = "Only one data_offset argument pair allowed"; 1189 rs->ti->error = "Only one data_offset argument pair allowed";
@@ -1195,7 +1195,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1195 return -EINVAL; 1195 return -EINVAL;
1196 } 1196 }
1197 rs->data_offset = value; 1197 rs->data_offset = value;
1198 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_DELTA_DISKS))) { 1198 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_DELTA_DISKS))) {
1199 /* Define the +/-# of disks to add to/remove from the given raid set */ 1199 /* Define the +/-# of disks to add to/remove from the given raid set */
1200 if (_test_and_set_flag(CTR_FLAG_DELTA_DISKS, &rs->ctr_flags)) { 1200 if (_test_and_set_flag(CTR_FLAG_DELTA_DISKS, &rs->ctr_flags)) {
1201 rs->ti->error = "Only one delta_disks argument pair allowed"; 1201 rs->ti->error = "Only one delta_disks argument pair allowed";
@@ -1208,7 +1208,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1208 } 1208 }
1209 1209
1210 rs->delta_disks = value; 1210 rs->delta_disks = value;
1211 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_STRIPE_CACHE))) { 1211 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_STRIPE_CACHE))) {
1212 if (_test_and_set_flag(CTR_FLAG_STRIPE_CACHE, &rs->ctr_flags)) { 1212 if (_test_and_set_flag(CTR_FLAG_STRIPE_CACHE, &rs->ctr_flags)) {
1213 rs->ti->error = "Only one stripe_cache argument pair allowed"; 1213 rs->ti->error = "Only one stripe_cache argument pair allowed";
1214 return -EINVAL; 1214 return -EINVAL;
@@ -1229,7 +1229,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1229 return -EINVAL; 1229 return -EINVAL;
1230 } 1230 }
1231 1231
1232 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_MIN_RECOVERY_RATE))) { 1232 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_MIN_RECOVERY_RATE))) {
1233 if (_test_and_set_flag(CTR_FLAG_MIN_RECOVERY_RATE, &rs->ctr_flags)) { 1233 if (_test_and_set_flag(CTR_FLAG_MIN_RECOVERY_RATE, &rs->ctr_flags)) {
1234 rs->ti->error = "Only one min_recovery_rate argument pair allowed"; 1234 rs->ti->error = "Only one min_recovery_rate argument pair allowed";
1235 return -EINVAL; 1235 return -EINVAL;
@@ -1239,7 +1239,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1239 return -EINVAL; 1239 return -EINVAL;
1240 } 1240 }
1241 rs->md.sync_speed_min = (int)value; 1241 rs->md.sync_speed_min = (int)value;
1242 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_MAX_RECOVERY_RATE))) { 1242 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_MAX_RECOVERY_RATE))) {
1243 if (_test_and_set_flag(CTR_FLAG_MIN_RECOVERY_RATE, &rs->ctr_flags)) { 1243 if (_test_and_set_flag(CTR_FLAG_MIN_RECOVERY_RATE, &rs->ctr_flags)) {
1244 rs->ti->error = "Only one max_recovery_rate argument pair allowed"; 1244 rs->ti->error = "Only one max_recovery_rate argument pair allowed";
1245 return -EINVAL; 1245 return -EINVAL;
@@ -1249,14 +1249,14 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
1249 return -EINVAL; 1249 return -EINVAL;
1250 } 1250 }
1251 rs->md.sync_speed_max = (int)value; 1251 rs->md.sync_speed_max = (int)value;
1252 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_REGION_SIZE))) { 1252 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_REGION_SIZE))) {
1253 if (_test_and_set_flag(CTR_FLAG_REGION_SIZE, &rs->ctr_flags)) { 1253 if (_test_and_set_flag(CTR_FLAG_REGION_SIZE, &rs->ctr_flags)) {
1254 rs->ti->error = "Only one region_size argument pair allowed"; 1254 rs->ti->error = "Only one region_size argument pair allowed";
1255 return -EINVAL; 1255 return -EINVAL;
1256 } 1256 }
1257 1257
1258 region_size = value; 1258 region_size = value;
1259 } else if (!strcasecmp(key, _argname_by_flag(CTR_FLAG_RAID10_COPIES))) { 1259 } else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_RAID10_COPIES))) {
1260 if (_test_and_set_flag(CTR_FLAG_RAID10_COPIES, &rs->ctr_flags)) { 1260 if (_test_and_set_flag(CTR_FLAG_RAID10_COPIES, &rs->ctr_flags)) {
1261 rs->ti->error = "Only one raid10_copies argument pair allowed"; 1261 rs->ti->error = "Only one raid10_copies argument pair allowed";
1262 return -EINVAL; 1262 return -EINVAL;
@@ -2625,46 +2625,46 @@ static void raid_status(struct dm_target *ti, status_type_t type,
2625 /* Emit table line */ 2625 /* Emit table line */
2626 DMEMIT("%s %u %u", rs->raid_type->name, raid_param_cnt, mddev->new_chunk_sectors); 2626 DMEMIT("%s %u %u", rs->raid_type->name, raid_param_cnt, mddev->new_chunk_sectors);
2627 if (_test_flag(CTR_FLAG_RAID10_FORMAT, rs->ctr_flags)) 2627 if (_test_flag(CTR_FLAG_RAID10_FORMAT, rs->ctr_flags))
2628 DMEMIT(" %s %s", _argname_by_flag(CTR_FLAG_RAID10_FORMAT), 2628 DMEMIT(" %s %s", dm_raid_arg_name_by_flag(CTR_FLAG_RAID10_FORMAT),
2629 raid10_md_layout_to_format(mddev->layout)); 2629 raid10_md_layout_to_format(mddev->layout));
2630 if (_test_flag(CTR_FLAG_RAID10_COPIES, rs->ctr_flags)) 2630 if (_test_flag(CTR_FLAG_RAID10_COPIES, rs->ctr_flags))
2631 DMEMIT(" %s %d", _argname_by_flag(CTR_FLAG_RAID10_COPIES), 2631 DMEMIT(" %s %d", dm_raid_arg_name_by_flag(CTR_FLAG_RAID10_COPIES),
2632 raid10_md_layout_to_copies(mddev->layout)); 2632 raid10_md_layout_to_copies(mddev->layout));
2633 if (_test_flag(CTR_FLAG_NOSYNC, rs->ctr_flags)) 2633 if (_test_flag(CTR_FLAG_NOSYNC, rs->ctr_flags))
2634 DMEMIT(" %s", _argname_by_flag(CTR_FLAG_NOSYNC)); 2634 DMEMIT(" %s", dm_raid_arg_name_by_flag(CTR_FLAG_NOSYNC));
2635 if (_test_flag(CTR_FLAG_SYNC, rs->ctr_flags)) 2635 if (_test_flag(CTR_FLAG_SYNC, rs->ctr_flags))
2636 DMEMIT(" %s", _argname_by_flag(CTR_FLAG_SYNC)); 2636 DMEMIT(" %s", dm_raid_arg_name_by_flag(CTR_FLAG_SYNC));
2637 if (_test_flag(CTR_FLAG_REGION_SIZE, rs->ctr_flags)) 2637 if (_test_flag(CTR_FLAG_REGION_SIZE, rs->ctr_flags))
2638 DMEMIT(" %s %llu", _argname_by_flag(CTR_FLAG_REGION_SIZE), 2638 DMEMIT(" %s %llu", dm_raid_arg_name_by_flag(CTR_FLAG_REGION_SIZE),
2639 (unsigned long long) to_sector(mddev->bitmap_info.chunksize)); 2639 (unsigned long long) to_sector(mddev->bitmap_info.chunksize));
2640 if (_test_flag(CTR_FLAG_DATA_OFFSET, rs->ctr_flags)) 2640 if (_test_flag(CTR_FLAG_DATA_OFFSET, rs->ctr_flags))
2641 DMEMIT(" %s %llu", _argname_by_flag(CTR_FLAG_DATA_OFFSET), 2641 DMEMIT(" %s %llu", dm_raid_arg_name_by_flag(CTR_FLAG_DATA_OFFSET),
2642 (unsigned long long) rs->data_offset); 2642 (unsigned long long) rs->data_offset);
2643 if (_test_flag(CTR_FLAG_DAEMON_SLEEP, rs->ctr_flags)) 2643 if (_test_flag(CTR_FLAG_DAEMON_SLEEP, rs->ctr_flags))
2644 DMEMIT(" %s %lu", _argname_by_flag(CTR_FLAG_DAEMON_SLEEP), 2644 DMEMIT(" %s %lu", dm_raid_arg_name_by_flag(CTR_FLAG_DAEMON_SLEEP),
2645 mddev->bitmap_info.daemon_sleep); 2645 mddev->bitmap_info.daemon_sleep);
2646 if (_test_flag(CTR_FLAG_DELTA_DISKS, rs->ctr_flags)) 2646 if (_test_flag(CTR_FLAG_DELTA_DISKS, rs->ctr_flags))
2647 DMEMIT(" %s %d", _argname_by_flag(CTR_FLAG_DELTA_DISKS), 2647 DMEMIT(" %s %d", dm_raid_arg_name_by_flag(CTR_FLAG_DELTA_DISKS),
2648 mddev->delta_disks); 2648 mddev->delta_disks);
2649 if (_test_flag(CTR_FLAG_STRIPE_CACHE, rs->ctr_flags)) 2649 if (_test_flag(CTR_FLAG_STRIPE_CACHE, rs->ctr_flags))
2650 DMEMIT(" %s %d", _argname_by_flag(CTR_FLAG_STRIPE_CACHE), 2650 DMEMIT(" %s %d", dm_raid_arg_name_by_flag(CTR_FLAG_STRIPE_CACHE),
2651 max_nr_stripes); 2651 max_nr_stripes);
2652 rdev_for_each(rdev, mddev) 2652 rdev_for_each(rdev, mddev)
2653 if (test_bit(rdev->raid_disk, (void *) rs->rebuild_disks)) 2653 if (test_bit(rdev->raid_disk, (void *) rs->rebuild_disks))
2654 DMEMIT(" %s %u", _argname_by_flag(CTR_FLAG_REBUILD), 2654 DMEMIT(" %s %u", dm_raid_arg_name_by_flag(CTR_FLAG_REBUILD),
2655 rdev->raid_disk); 2655 rdev->raid_disk);
2656 rdev_for_each(rdev, mddev) 2656 rdev_for_each(rdev, mddev)
2657 if (test_bit(WriteMostly, &rdev->flags)) 2657 if (test_bit(WriteMostly, &rdev->flags))
2658 DMEMIT(" %s %d", _argname_by_flag(CTR_FLAG_WRITE_MOSTLY), 2658 DMEMIT(" %s %d", dm_raid_arg_name_by_flag(CTR_FLAG_WRITE_MOSTLY),
2659 rdev->raid_disk); 2659 rdev->raid_disk);
2660 if (_test_flag(CTR_FLAG_MAX_WRITE_BEHIND, rs->ctr_flags)) 2660 if (_test_flag(CTR_FLAG_MAX_WRITE_BEHIND, rs->ctr_flags))
2661 DMEMIT(" %s %lu", _argname_by_flag(CTR_FLAG_MAX_WRITE_BEHIND), 2661 DMEMIT(" %s %lu", dm_raid_arg_name_by_flag(CTR_FLAG_MAX_WRITE_BEHIND),
2662 mddev->bitmap_info.max_write_behind); 2662 mddev->bitmap_info.max_write_behind);
2663 if (_test_flag(CTR_FLAG_MAX_RECOVERY_RATE, rs->ctr_flags)) 2663 if (_test_flag(CTR_FLAG_MAX_RECOVERY_RATE, rs->ctr_flags))
2664 DMEMIT(" %s %d", _argname_by_flag(CTR_FLAG_MAX_RECOVERY_RATE), 2664 DMEMIT(" %s %d", dm_raid_arg_name_by_flag(CTR_FLAG_MAX_RECOVERY_RATE),
2665 mddev->sync_speed_max); 2665 mddev->sync_speed_max);
2666 if (_test_flag(CTR_FLAG_MIN_RECOVERY_RATE, rs->ctr_flags)) 2666 if (_test_flag(CTR_FLAG_MIN_RECOVERY_RATE, rs->ctr_flags))
2667 DMEMIT(" %s %d", _argname_by_flag(CTR_FLAG_MIN_RECOVERY_RATE), 2667 DMEMIT(" %s %d", dm_raid_arg_name_by_flag(CTR_FLAG_MIN_RECOVERY_RATE),
2668 mddev->sync_speed_min); 2668 mddev->sync_speed_min);
2669 DMEMIT(" %d", rs->raid_disks); 2669 DMEMIT(" %d", rs->raid_disks);
2670 rdev_for_each(rdev, mddev) { 2670 rdev_for_each(rdev, mddev) {