diff options
author | Tom Gundersen <teg@jklm.no> | 2016-09-21 10:59:19 -0400 |
---|---|---|
committer | Sean Paul <seanpaul@chromium.org> | 2016-09-22 07:03:48 -0400 |
commit | 0f2886057be322ddfa4858384c40a505f7a32a4a (patch) | |
tree | 95fd93e32cce031f99920cd1937b4e46491e65b3 /drivers/gpu/drm/vgem | |
parent | c6bf811a0b55ab224fb2c75345641b4bb599475c (diff) |
drm: Don't swallow error codes in drm_dev_alloc()
There are many reasons other than ENOMEM that drm_dev_init() can
fail. Return ERR_PTR rather than NULL to be able to distinguish
these in the caller.
Signed-off-by: Tom Gundersen <teg@jklm.no>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/20160921145919.13754-2-teg@jklm.no
Diffstat (limited to 'drivers/gpu/drm/vgem')
-rw-r--r-- | drivers/gpu/drm/vgem/vgem_drv.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index c15bafb06665..f36c14729b55 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c | |||
@@ -334,8 +334,8 @@ static int __init vgem_init(void) | |||
334 | int ret; | 334 | int ret; |
335 | 335 | ||
336 | vgem_device = drm_dev_alloc(&vgem_driver, NULL); | 336 | vgem_device = drm_dev_alloc(&vgem_driver, NULL); |
337 | if (!vgem_device) { | 337 | if (IS_ERR(vgem_device)) { |
338 | ret = -ENOMEM; | 338 | ret = PTR_ERR(vgem_device); |
339 | goto out; | 339 | goto out; |
340 | } | 340 | } |
341 | 341 | ||