aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/fpga/fpga-region.c
diff options
context:
space:
mode:
authorAlan Tull <atull@kernel.org>2017-11-15 15:20:14 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-11-28 10:30:37 -0500
commitc3d971ad32fc19af638ac6f6ffe041aa1ff722b5 (patch)
tree06f5b1e8341680d4e51de0744a7e94f818ac2e03 /drivers/fpga/fpga-region.c
parentebf877a51ad7b65e4ab024f021b60a4f7928864a (diff)
fpga: region: use dev_err instead of pr_err
Use dev_err messages instead of pr_err. Also s/&region->dev/dev/ in two places where we already have dev = &region->dev. Signed-off-by: Alan Tull <atull@kernel.org> Acked-by: Moritz Fischer <mdf@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/fpga/fpga-region.c')
-rw-r--r--drivers/fpga/fpga-region.c20
1 files changed, 10 insertions, 10 deletions
diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
index 1e1640a29306..6b4f9abed043 100644
--- a/drivers/fpga/fpga-region.c
+++ b/drivers/fpga/fpga-region.c
@@ -102,7 +102,7 @@ static struct fpga_region *fpga_region_get(struct fpga_region *region)
102 return ERR_PTR(-ENODEV); 102 return ERR_PTR(-ENODEV);
103 } 103 }
104 104
105 dev_dbg(&region->dev, "get\n"); 105 dev_dbg(dev, "get\n");
106 106
107 return region; 107 return region;
108} 108}
@@ -116,7 +116,7 @@ static void fpga_region_put(struct fpga_region *region)
116{ 116{
117 struct device *dev = &region->dev; 117 struct device *dev = &region->dev;
118 118
119 dev_dbg(&region->dev, "put\n"); 119 dev_dbg(dev, "put\n");
120 120
121 module_put(dev->parent->driver->owner); 121 module_put(dev->parent->driver->owner);
122 of_node_put(dev->of_node); 122 of_node_put(dev->of_node);
@@ -239,13 +239,13 @@ static int fpga_region_program_fpga(struct fpga_region *region,
239 239
240 region = fpga_region_get(region); 240 region = fpga_region_get(region);
241 if (IS_ERR(region)) { 241 if (IS_ERR(region)) {
242 pr_err("failed to get fpga region\n"); 242 dev_err(dev, "failed to get FPGA region\n");
243 return PTR_ERR(region); 243 return PTR_ERR(region);
244 } 244 }
245 245
246 mgr = fpga_region_get_manager(region); 246 mgr = fpga_region_get_manager(region);
247 if (IS_ERR(mgr)) { 247 if (IS_ERR(mgr)) {
248 pr_err("failed to get fpga region manager\n"); 248 dev_err(dev, "failed to get FPGA manager\n");
249 ret = PTR_ERR(mgr); 249 ret = PTR_ERR(mgr);
250 goto err_put_region; 250 goto err_put_region;
251 } 251 }
@@ -258,25 +258,25 @@ static int fpga_region_program_fpga(struct fpga_region *region,
258 258
259 ret = fpga_region_get_bridges(region, overlay); 259 ret = fpga_region_get_bridges(region, overlay);
260 if (ret) { 260 if (ret) {
261 pr_err("failed to get fpga region bridges\n"); 261 dev_err(dev, "failed to get FPGA bridges\n");
262 goto err_unlock_mgr; 262 goto err_unlock_mgr;
263 } 263 }
264 264
265 ret = fpga_bridges_disable(&region->bridge_list); 265 ret = fpga_bridges_disable(&region->bridge_list);
266 if (ret) { 266 if (ret) {
267 pr_err("failed to disable region bridges\n"); 267 dev_err(dev, "failed to disable bridges\n");
268 goto err_put_br; 268 goto err_put_br;
269 } 269 }
270 270
271 ret = fpga_mgr_load(mgr, region->info); 271 ret = fpga_mgr_load(mgr, region->info);
272 if (ret) { 272 if (ret) {
273 pr_err("failed to load fpga image\n"); 273 dev_err(dev, "failed to load FPGA image\n");
274 goto err_put_br; 274 goto err_put_br;
275 } 275 }
276 276
277 ret = fpga_bridges_enable(&region->bridge_list); 277 ret = fpga_bridges_enable(&region->bridge_list);
278 if (ret) { 278 if (ret) {
279 pr_err("failed to enable region bridges\n"); 279 dev_err(dev, "failed to enable region bridges\n");
280 goto err_put_br; 280 goto err_put_br;
281 } 281 }
282 282
@@ -407,7 +407,7 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region,
407 407
408 /* If FPGA was externally programmed, don't specify firmware */ 408 /* If FPGA was externally programmed, don't specify firmware */
409 if ((info->flags & FPGA_MGR_EXTERNAL_CONFIG) && info->firmware_name) { 409 if ((info->flags & FPGA_MGR_EXTERNAL_CONFIG) && info->firmware_name) {
410 pr_err("error: specified firmware and external-fpga-config"); 410 dev_err(dev, "error: specified firmware and external-fpga-config");
411 fpga_image_info_free(info); 411 fpga_image_info_free(info);
412 return -EINVAL; 412 return -EINVAL;
413 } 413 }
@@ -420,7 +420,7 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region,
420 420
421 /* If we got this far, we should be programming the FPGA */ 421 /* If we got this far, we should be programming the FPGA */
422 if (!info->firmware_name) { 422 if (!info->firmware_name) {
423 pr_err("should specify firmware-name or external-fpga-config\n"); 423 dev_err(dev, "should specify firmware-name or external-fpga-config\n");
424 fpga_image_info_free(info); 424 fpga_image_info_free(info);
425 return -EINVAL; 425 return -EINVAL;
426 } 426 }