diff options
author | Christoph Hellwig <hch@lst.de> | 2017-04-20 10:02:55 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2017-04-20 14:16:10 -0400 |
commit | b7819b9259185dcdcc81eb32182a4dc13d695738 (patch) | |
tree | 96d76ffadf2718b65faf6004b734ed6b094f30ae /drivers/cdrom/cdrom.c | |
parent | 75a500ef6ecb6266d4d1347fc7eb4b298b566b3b (diff) |
block: remove the blk_execute_rq return value
The function only returns -EIO if rq->errors is non-zero, which is not
very useful and lets a large number of callers ignore the return value.
Just let the callers figure out their error themselves.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/cdrom/cdrom.c')
-rw-r--r-- | drivers/cdrom/cdrom.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 87739649eac2..308501730ab3 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c | |||
@@ -2218,7 +2218,8 @@ static int cdrom_read_cdda_bpc(struct cdrom_device_info *cdi, __u8 __user *ubuf, | |||
2218 | rq->timeout = 60 * HZ; | 2218 | rq->timeout = 60 * HZ; |
2219 | bio = rq->bio; | 2219 | bio = rq->bio; |
2220 | 2220 | ||
2221 | if (blk_execute_rq(q, cdi->disk, rq, 0)) { | 2221 | blk_execute_rq(q, cdi->disk, rq, 0); |
2222 | if (rq->errors) { | ||
2222 | struct request_sense *s = req->sense; | 2223 | struct request_sense *s = req->sense; |
2223 | ret = -EIO; | 2224 | ret = -EIO; |
2224 | cdi->last_sense = s->sense_key; | 2225 | cdi->last_sense = s->sense_key; |