aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/acpi/button.c
diff options
context:
space:
mode:
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>2017-06-06 18:57:37 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2017-06-06 18:57:37 -0400
commitf3b7eaae1b35eb8077610eb7c7db042c9b0645e1 (patch)
tree40cf431ba24ff06e8f2f9a55b056707660b1421a /drivers/acpi/button.c
parent0bae5fd3330be0517fba697e6b228601d421fade (diff)
Revert "ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle"
Revert commit eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle) as it turned out to be premature and triggered a number of different issues on various systems. That includes, but is not limited to, premature suspend-to-RAM aborts on Dell XPS 13 (9343) reported by Dominik. The issue the commit in question attempted to address is real and will need to be taken care of going forward, but evidently more work is needed for this purpose. Reported-by: Dominik Brodowski <linux@dominikbrodowski.net> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/button.c')
-rw-r--r--drivers/acpi/button.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index b7c2a06963d6..668137e4a069 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -216,7 +216,7 @@ static int acpi_lid_notify_state(struct acpi_device *device, int state)
216 } 216 }
217 217
218 if (state) 218 if (state)
219 pm_wakeup_hard_event(&device->dev); 219 pm_wakeup_event(&device->dev, 0);
220 220
221 ret = blocking_notifier_call_chain(&acpi_lid_notifier, state, device); 221 ret = blocking_notifier_call_chain(&acpi_lid_notifier, state, device);
222 if (ret == NOTIFY_DONE) 222 if (ret == NOTIFY_DONE)
@@ -398,7 +398,7 @@ static void acpi_button_notify(struct acpi_device *device, u32 event)
398 } else { 398 } else {
399 int keycode; 399 int keycode;
400 400
401 pm_wakeup_hard_event(&device->dev); 401 pm_wakeup_event(&device->dev, 0);
402 if (button->suspended) 402 if (button->suspended)
403 break; 403 break;
404 404
@@ -530,7 +530,6 @@ static int acpi_button_add(struct acpi_device *device)
530 lid_device = device; 530 lid_device = device;
531 } 531 }
532 532
533 device_init_wakeup(&device->dev, true);
534 printk(KERN_INFO PREFIX "%s [%s]\n", name, acpi_device_bid(device)); 533 printk(KERN_INFO PREFIX "%s [%s]\n", name, acpi_device_bid(device));
535 return 0; 534 return 0;
536 535