litmus-rt-ext-res.git/drivers/scsi/bfa, branch EXT-RES

scsi: bfa: Do not dereference port before it is null checked

2016-09-02T10:09:16+00:00

Port is deferenced before it is null sanity checked, hence we
potentially have a null pointer dereference bug. Instead, initialise
trl_enabled from port->fcs->bfa after we are sure port is not null.

Signed-off-by: Colin Ian King 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scripts/spelling.txt: add "fimware" misspelling

2016-05-20T02:12:14+00:00

A few instances of "fimware" instead of "firmware" were found.  Fix
these and add it to the spelling.txt file.

Signed-off-by: Kees Cook 
Reported-by: Randy Dunlap 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

bfa: fix bfa_fcb_itnim_alloc() error handling

2016-05-10T02:18:42+00:00

The caller assumes that "itnim" is NULL on error and non-NULL on success
but really "itnim" is uninitialized on error.  This function should just
use normal error handling where it returns zero on success and negative
on failure.

Signed-off-by: Dan Carpenter 
Acked-by: Anil Gurumurthy 
Signed-off-by: Martin K. Petersen

bfa: deinline __bfa_trc() and __bfa_trc32()

2016-02-24T02:27:02+00:00

__bfa_trc() compiles to 115 bytes of machine code.
With this .config: http://busybox.net/~vda/kernel_config
there are 1494 calls of __bfa_trc().

__bfa_trc32() is very similar, so it is uninlined too.
However, it appears to be unused, therefore this patch
ifdefs it out.

Change in code size is about 130,000 bytes:

    text     data      bss       dec     hex filename
85975426 22294712 20627456 128897594 7aed23a vmlinux.before
85842882 22294584 20627456 128764922 7accbfa vmlinux

[mkp: Removed unused __bfa_trc32()]

Signed-off-by: Denys Vlasenko 
Acked-by: Anil Gurumurthy 
CC: Fabian Frederick 
CC: Anil Gurumurthy 
CC: Christoph Hellwig 
CC: Guenter Roeck 
CC: Ben Hutchings 
CC: James Bottomley 
CC: linux-kernel@vger.kernel.org
CC: linux-scsi@vger.kernel.org
Signed-off-by: Martin K. Petersen

bfa: use strncpy() instead of memcpy()

2016-02-24T02:27:02+00:00

BFA_MFG_NAME is "QLogic" which is only 7 bytes, but we are copying 8
bytes.  It's harmless because the badding byte is likely zero but it
makes static checkers complain.

Signed-off-by: Dan Carpenter 
Acked-by: Anil Gurumurthy 
Signed-off-by: Martin K. Petersen

bfa: Update driver version to 3.2.25.0

2015-12-02T22:07:57+00:00

Signed-off-by: Sudarsana Kalluru 
Signed-off-by: Anil Gurumurthy 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

bfa: File header and user visible string changes

2015-12-02T22:07:38+00:00

Signed-off-by: Sudarsana Kalluru 
Signed-off-by: Anil Gurumurthy 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

bfa: Fix for crash when bfa_itnim is NULL

2015-12-02T22:06:45+00:00

Fix a very corner case when the port gets disconnected and the BFA and
FCS layers clean up references to the IT nexus.  During this window if a
task management command is issued by the SCSI-ML and ends up referencing
a NULL itnim, it could lead to a crash.

Signed-off-by: Sudarsana Kalluru 
Signed-off-by: Anil Gurumurthy 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

bfa: Update copyright messages

2015-12-02T22:05:45+00:00

Signed-off-by: Sudarsana Kalluru 
Signed-off-by: Anil Gurumurthy 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: use host wide tags by default

2015-11-10T01:11:57+00:00

This patch changes the !blk-mq path to the same defaults as the blk-mq
I/O path by always enabling block tagging, and always using host wide
tags.  We've had blk-mq available for a few releases so bugs with
this mode should have been ironed out, and this ensures we get better
coverage of over tagging setup over different configs.

Signed-off-by: Christoph Hellwig 
Acked-by: Jens Axboe 
Reviewed-by: Hannes Reinecke 
Signed-off-by: James Bottomley