litmus-rt-ext-res.git/drivers/crypto/sunxi-ss, branch EXT-RES

crypto: sun4i-ss - mark sun4i_hash() static

2016-09-22T10:32:48+00:00

We get 1 warning when building kernel with W=1:
drivers/crypto/sunxi-ss/sun4i-ss-hash.c:168:5: warning: no previous prototype for 'sun4i_hash' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.

Signed-off-by: Baoyou Xie 
Signed-off-by: Herbert Xu

crypto: sun4i-ss - fix missing unlock on error in sun4i_hash()

2016-08-24T13:04:49+00:00

Add the missing unlock before return from function sun4i_hash()
in the error handling case.

Fixes: 477d9b2e591b ("crypto: sun4i-ss - unify update/final function")
Signed-off-by: Wei Yongjun 
Acked-by: Corentin LABBE 
Signed-off-by: Herbert Xu

crypto: sun4i-ss - fix indentation of two crypto alg

2016-08-16T09:17:02+00:00

Two crypto alg are badly indented, this patch fix this style issue.

Signed-off-by: LABBE Corentin 
Signed-off-by: Herbert Xu

crypto: sun4i-ss - Always use sun4i_tfm_ctx for storing pointer to dev ss

2016-08-16T09:17:00+00:00

The dev *ss is stored both in sun4i_tfm_ctx and sun4i_req_ctx.
Since this pointer will never be changed during tfm life, it is better
to remove it from sun4i_req_ctx.

Signed-off-by: LABBE Corentin 
Signed-off-by: Herbert Xu

crypto: sun4i-ss - fix spelling

2016-08-16T09:16:59+00:00

Two words are badly spelled, this patch respell them.

Signed-off-by: LABBE Corentin 
Signed-off-by: Herbert Xu

crypto: sun4i-ss - clean unused ss

2016-08-16T09:16:57+00:00

The ss variable is never used, remove it.

Signed-off-by: LABBE Corentin 
Signed-off-by: Herbert Xu

crypto: sun4i-ss - unify update/final function

2016-08-16T09:16:56+00:00

The update and final functions have lots of common action.
This patch mix them in one function.
This will give some improvements:
- This will permit asynchronous support more easily
- This will permit to use finup/digest functions with some performance
  improvements

Signed-off-by: LABBE Corentin 
Signed-off-by: Herbert Xu

crypto: sun4i-ss - fix a few signed warning

2016-08-16T09:16:54+00:00

The variable i is always checked against unsigned value and cannot be
negative.
This patch set it as unsigned.

Signed-off-by: LABBE Corentin 
Signed-off-by: Herbert Xu

crypto: sun4i-ss - Replace spinlock_bh by spin_lock_irq{save|restore}

2016-04-05T12:35:53+00:00

The current sun4i-ss driver could generate data corruption when ciphering/deciphering.
It occurs randomly on end of handled data.
No root cause have been found and the only way to remove it is to replace
all spin_lock_bh by their irq counterparts.

Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator")
Signed-off-by: LABBE Corentin 
Cc: stable 
Signed-off-by: Herbert Xu

crypto: sunxi - don't print confusing data

2016-01-27T12:36:26+00:00

gcc correctly warns that the printk output contains a variable that
it thinks is not initialized in some cases:

drivers/crypto/sunxi-ss/sun4i-ss-cipher.c: In function 'sun4i_ss_cipher_poll':
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:254:76: warning: 'todo' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:144:15: note: 'todo' was declared here

A closer look at the function reveals that the variable is always
initialized at this point (ileft is guaranteed to be positive at the
start), but its contents are not well-defined:
Depending on some other variables, it might be either a count in
words or bytes, and it could refer to either input or output.

The easiest solution apparently is to remove the confusing output
and let the reader figure out the state from the other variables.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Herbert Xu