1 files changed, 9 insertions, 71 deletions

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 5d3bbcd279b4..665668b6f2b1 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -23,7 +23,6 @@
 #include <linux/dmaengine.h>
 #include <linux/amba/bus.h>
 #include <linux/amba/pl330.h>
-#include <linux/pm_runtime.h>
 #include <linux/scatterlist.h>
 #include <linux/of.h>
 
@@ -586,8 +585,6 @@ struct dma_pl330_dmac {
 
         /* Peripheral channels connected to this DMAC */
         struct dma_pl330_chan *peripherals; /* keep at end */
-
-        struct clk *clk;
 };
 
 struct dma_pl330_desc {
@@ -2395,7 +2392,7 @@ static int pl330_alloc_chan_resources(struct dma_chan *chan)
         pch->pl330_chid = pl330_request_channel(&pdmac->pif);
         if (!pch->pl330_chid) {
                 spin_unlock_irqrestore(&pch->lock, flags);
-                return 0;
+                return -ENOMEM;
         }
 
         tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
@@ -2685,7 +2682,7 @@ static inline int get_burst_len(struct dma_pl330_desc *desc, size_t len)
 static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
                 struct dma_chan *chan, dma_addr_t dma_addr, size_t len,
                 size_t period_len, enum dma_transfer_direction direction,
-                void *context)
+                unsigned long flags, void *context)
 {
         struct dma_pl330_desc *desc;
         struct dma_pl330_chan *pch = to_pchan(chan);
@@ -2889,29 +2886,17 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
                 goto probe_err1;
         }
 
-        pdmac->clk = clk_get(&adev->dev, "dma");
-        if (IS_ERR(pdmac->clk)) {
-                dev_err(&adev->dev, "Cannot get operation clock.\n");
-                ret = -EINVAL;
-                goto probe_err2;
-        }
-
         amba_set_drvdata(adev, pdmac);
 
-#ifndef CONFIG_PM_RUNTIME
-        /* enable dma clk */
-        clk_enable(pdmac->clk);
-#endif
-
         irq = adev->irq[0];
         ret = request_irq(irq, pl330_irq_handler, 0,
                         dev_name(&adev->dev), pi);
         if (ret)
-                goto probe_err3;
+                goto probe_err2;
 
         ret = pl330_add(pi);
         if (ret)
-                goto probe_err4;
+                goto probe_err3;
 
         INIT_LIST_HEAD(&pdmac->desc_pool);
         spin_lock_init(&pdmac->pool_lock);
@@ -2933,7 +2918,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
         if (!pdmac->peripherals) {
                 ret = -ENOMEM;
                 dev_err(&adev->dev, "unable to allocate pdmac->peripherals\n");
-                goto probe_err5;
+                goto probe_err4;
         }
 
         for (i = 0; i < num_chan; i++) {
@@ -2961,6 +2946,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
                 if (pi->pcfg.num_peri) {
                         dma_cap_set(DMA_SLAVE, pd->cap_mask);
                         dma_cap_set(DMA_CYCLIC, pd->cap_mask);
+                        dma_cap_set(DMA_PRIVATE, pd->cap_mask);
                 }
         }
 
@@ -2976,7 +2962,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
         ret = dma_async_device_register(pd);
         if (ret) {
                 dev_err(&adev->dev, "unable to register DMAC\n");
-                goto probe_err5;
+                goto probe_err4;
         }
 
         dev_info(&adev->dev,
@@ -2989,15 +2975,10 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
 
         return 0;
 
-probe_err5:
-        pl330_del(pi);
 probe_err4:
-        free_irq(irq, pi);
+        pl330_del(pi);
 probe_err3:
-#ifndef CONFIG_PM_RUNTIME
-        clk_disable(pdmac->clk);
-#endif
-        clk_put(pdmac->clk);
+        free_irq(irq, pi);
 probe_err2:
         iounmap(pi->base);
 probe_err1:
@@ -3044,10 +3025,6 @@ static int __devexit pl330_remove(struct amba_device *adev)
         res = &adev->res;
         release_mem_region(res->start, resource_size(res));
 
-#ifndef CONFIG_PM_RUNTIME
-        clk_disable(pdmac->clk);
-#endif
-
         kfree(pdmac);
 
         return 0;
@@ -3063,49 +3040,10 @@ static struct amba_id pl330_ids[] = {
 
 MODULE_DEVICE_TABLE(amba, pl330_ids);
 
-#ifdef CONFIG_PM_RUNTIME
-static int pl330_runtime_suspend(struct device *dev)
-{
-        struct dma_pl330_dmac *pdmac = dev_get_drvdata(dev);
-
-        if (!pdmac) {
-                dev_err(dev, "failed to get dmac\n");
-                return -ENODEV;
-        }
-
-        clk_disable(pdmac->clk);
-
-        return 0;
-}
-
-static int pl330_runtime_resume(struct device *dev)
-{
-        struct dma_pl330_dmac *pdmac = dev_get_drvdata(dev);
-
-        if (!pdmac) {
-                dev_err(dev, "failed to get dmac\n");
-                return -ENODEV;
-        }
-
-        clk_enable(pdmac->clk);
-
-        return 0;
-}
-#else
-#define pl330_runtime_suspend   NULL
-#define pl330_runtime_resume    NULL
-#endif /* CONFIG_PM_RUNTIME */
-
-static const struct dev_pm_ops pl330_pm_ops = {
-        .runtime_suspend = pl330_runtime_suspend,
-        .runtime_resume = pl330_runtime_resume,
-};
-
 static struct amba_driver pl330_driver = {
         .drv = {
                 .owner = THIS_MODULE,
                 .name = "dma-pl330",
-                .pm = &pl330_pm_ops,
         },
         .id_table = pl330_ids,
         .probe = pl330_probe,