diff options
-rw-r--r-- | drivers/net/caif/caif_hsi.c | 2 | ||||
-rw-r--r-- | drivers/net/caif/caif_serial.c | 4 | ||||
-rw-r--r-- | drivers/net/caif/caif_shmcore.c | 6 | ||||
-rw-r--r-- | net/caif/caif_dev.c | 10 |
4 files changed, 12 insertions, 10 deletions
diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c index a85b29e797f0..0a4fc62a381d 100644 --- a/drivers/net/caif/caif_hsi.c +++ b/drivers/net/caif/caif_hsi.c | |||
@@ -933,7 +933,7 @@ static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev) | |||
933 | 933 | ||
934 | /* Create HSI frame. */ | 934 | /* Create HSI frame. */ |
935 | len = cfhsi_tx_frm(desc, cfhsi); | 935 | len = cfhsi_tx_frm(desc, cfhsi); |
936 | BUG_ON(!len); | 936 | WARN_ON(!len); |
937 | 937 | ||
938 | /* Set up new transfer. */ | 938 | /* Set up new transfer. */ |
939 | res = cfhsi->dev->cfhsi_tx(cfhsi->tx_buf, len, cfhsi->dev); | 939 | res = cfhsi->dev->cfhsi_tx(cfhsi->tx_buf, len, cfhsi->dev); |
diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c index 23406e62c0b0..9341a2d6efee 100644 --- a/drivers/net/caif/caif_serial.c +++ b/drivers/net/caif/caif_serial.c | |||
@@ -261,7 +261,7 @@ static int handle_tx(struct ser_device *ser) | |||
261 | skb_pull(skb, tty_wr); | 261 | skb_pull(skb, tty_wr); |
262 | if (skb->len == 0) { | 262 | if (skb->len == 0) { |
263 | struct sk_buff *tmp = skb_dequeue(&ser->head); | 263 | struct sk_buff *tmp = skb_dequeue(&ser->head); |
264 | BUG_ON(tmp != skb); | 264 | WARN_ON(tmp != skb); |
265 | if (in_interrupt()) | 265 | if (in_interrupt()) |
266 | dev_kfree_skb_irq(skb); | 266 | dev_kfree_skb_irq(skb); |
267 | else | 267 | else |
@@ -305,7 +305,7 @@ static void ldisc_tx_wakeup(struct tty_struct *tty) | |||
305 | 305 | ||
306 | ser = tty->disc_data; | 306 | ser = tty->disc_data; |
307 | BUG_ON(ser == NULL); | 307 | BUG_ON(ser == NULL); |
308 | BUG_ON(ser->tty != tty); | 308 | WARN_ON(ser->tty != tty); |
309 | handle_tx(ser); | 309 | handle_tx(ser); |
310 | } | 310 | } |
311 | 311 | ||
diff --git a/drivers/net/caif/caif_shmcore.c b/drivers/net/caif/caif_shmcore.c index fd59e37e28a1..5b2041319a32 100644 --- a/drivers/net/caif/caif_shmcore.c +++ b/drivers/net/caif/caif_shmcore.c | |||
@@ -337,7 +337,11 @@ static void shm_rx_work_func(struct work_struct *rx_work) | |||
337 | /* Get a suitable CAIF packet and copy in data. */ | 337 | /* Get a suitable CAIF packet and copy in data. */ |
338 | skb = netdev_alloc_skb(pshm_drv->pshm_dev->pshm_netdev, | 338 | skb = netdev_alloc_skb(pshm_drv->pshm_dev->pshm_netdev, |
339 | frm_pck_len + 1); | 339 | frm_pck_len + 1); |
340 | BUG_ON(skb == NULL); | 340 | |
341 | if (skb == NULL) { | ||
342 | pr_info("OOM: Try next frame in descriptor\n"); | ||
343 | break; | ||
344 | } | ||
341 | 345 | ||
342 | p = skb_put(skb, frm_pck_len); | 346 | p = skb_put(skb, frm_pck_len); |
343 | memcpy(p, pbuf->desc_vptr + frm_pck_ofs, frm_pck_len); | 347 | memcpy(p, pbuf->desc_vptr + frm_pck_ofs, frm_pck_len); |
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c index 9b298c14028d..b0ce14fbf6ef 100644 --- a/net/caif/caif_dev.c +++ b/net/caif/caif_dev.c | |||
@@ -58,7 +58,6 @@ static int q_high = 50; /* Percent */ | |||
58 | struct cfcnfg *get_cfcnfg(struct net *net) | 58 | struct cfcnfg *get_cfcnfg(struct net *net) |
59 | { | 59 | { |
60 | struct caif_net *caifn; | 60 | struct caif_net *caifn; |
61 | BUG_ON(!net); | ||
62 | caifn = net_generic(net, caif_net_id); | 61 | caifn = net_generic(net, caif_net_id); |
63 | if (!caifn) | 62 | if (!caifn) |
64 | return NULL; | 63 | return NULL; |
@@ -69,7 +68,6 @@ EXPORT_SYMBOL(get_cfcnfg); | |||
69 | static struct caif_device_entry_list *caif_device_list(struct net *net) | 68 | static struct caif_device_entry_list *caif_device_list(struct net *net) |
70 | { | 69 | { |
71 | struct caif_net *caifn; | 70 | struct caif_net *caifn; |
72 | BUG_ON(!net); | ||
73 | caifn = net_generic(net, caif_net_id); | 71 | caifn = net_generic(net, caif_net_id); |
74 | if (!caifn) | 72 | if (!caifn) |
75 | return NULL; | 73 | return NULL; |
@@ -507,15 +505,15 @@ static struct notifier_block caif_device_notifier = { | |||
507 | static int caif_init_net(struct net *net) | 505 | static int caif_init_net(struct net *net) |
508 | { | 506 | { |
509 | struct caif_net *caifn = net_generic(net, caif_net_id); | 507 | struct caif_net *caifn = net_generic(net, caif_net_id); |
510 | BUG_ON(!caifn); | 508 | if (WARN_ON(!caifn)) |
509 | return -EINVAL; | ||
510 | |||
511 | INIT_LIST_HEAD(&caifn->caifdevs.list); | 511 | INIT_LIST_HEAD(&caifn->caifdevs.list); |
512 | mutex_init(&caifn->caifdevs.lock); | 512 | mutex_init(&caifn->caifdevs.lock); |
513 | 513 | ||
514 | caifn->cfg = cfcnfg_create(); | 514 | caifn->cfg = cfcnfg_create(); |
515 | if (!caifn->cfg) { | 515 | if (!caifn->cfg) |
516 | pr_warn("can't create cfcnfg\n"); | ||
517 | return -ENOMEM; | 516 | return -ENOMEM; |
518 | } | ||
519 | 517 | ||
520 | return 0; | 518 | return 0; |
521 | } | 519 | } |