diff options
-rw-r--r-- | drivers/net/bonding/bond_main.c | 6 | ||||
-rw-r--r-- | drivers/net/team/team.c | 16 | ||||
-rw-r--r-- | include/linux/netdevice.h | 3 | ||||
-rw-r--r-- | include/linux/netpoll.h | 2 | ||||
-rw-r--r-- | net/8021q/vlan_dev.c | 7 | ||||
-rw-r--r-- | net/bridge/br_device.c | 15 | ||||
-rw-r--r-- | net/bridge/br_if.c | 2 | ||||
-rw-r--r-- | net/bridge/br_private.h | 4 | ||||
-rw-r--r-- | net/core/netpoll.c | 8 |
9 files changed, 29 insertions, 34 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 5be34b72a048..95a6ca7d9e51 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c | |||
@@ -922,12 +922,12 @@ static inline int slave_enable_netpoll(struct slave *slave) | |||
922 | struct netpoll *np; | 922 | struct netpoll *np; |
923 | int err = 0; | 923 | int err = 0; |
924 | 924 | ||
925 | np = kzalloc(sizeof(*np), GFP_ATOMIC); | 925 | np = kzalloc(sizeof(*np), GFP_KERNEL); |
926 | err = -ENOMEM; | 926 | err = -ENOMEM; |
927 | if (!np) | 927 | if (!np) |
928 | goto out; | 928 | goto out; |
929 | 929 | ||
930 | err = __netpoll_setup(np, slave->dev, GFP_ATOMIC); | 930 | err = __netpoll_setup(np, slave->dev); |
931 | if (err) { | 931 | if (err) { |
932 | kfree(np); | 932 | kfree(np); |
933 | goto out; | 933 | goto out; |
@@ -962,7 +962,7 @@ static void bond_netpoll_cleanup(struct net_device *bond_dev) | |||
962 | slave_disable_netpoll(slave); | 962 | slave_disable_netpoll(slave); |
963 | } | 963 | } |
964 | 964 | ||
965 | static int bond_netpoll_setup(struct net_device *dev, struct netpoll_info *ni, gfp_t gfp) | 965 | static int bond_netpoll_setup(struct net_device *dev, struct netpoll_info *ni) |
966 | { | 966 | { |
967 | struct bonding *bond = netdev_priv(dev); | 967 | struct bonding *bond = netdev_priv(dev); |
968 | struct list_head *iter; | 968 | struct list_head *iter; |
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 2b1a1d61072c..33008c1d1d67 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c | |||
@@ -1031,8 +1031,7 @@ static void team_port_leave(struct team *team, struct team_port *port) | |||
1031 | } | 1031 | } |
1032 | 1032 | ||
1033 | #ifdef CONFIG_NET_POLL_CONTROLLER | 1033 | #ifdef CONFIG_NET_POLL_CONTROLLER |
1034 | static int team_port_enable_netpoll(struct team *team, struct team_port *port, | 1034 | static int team_port_enable_netpoll(struct team *team, struct team_port *port) |
1035 | gfp_t gfp) | ||
1036 | { | 1035 | { |
1037 | struct netpoll *np; | 1036 | struct netpoll *np; |
1038 | int err; | 1037 | int err; |
@@ -1040,11 +1039,11 @@ static int team_port_enable_netpoll(struct team *team, struct team_port *port, | |||
1040 | if (!team->dev->npinfo) | 1039 | if (!team->dev->npinfo) |
1041 | return 0; | 1040 | return 0; |
1042 | 1041 | ||
1043 | np = kzalloc(sizeof(*np), gfp); | 1042 | np = kzalloc(sizeof(*np), GFP_KERNEL); |
1044 | if (!np) | 1043 | if (!np) |
1045 | return -ENOMEM; | 1044 | return -ENOMEM; |
1046 | 1045 | ||
1047 | err = __netpoll_setup(np, port->dev, gfp); | 1046 | err = __netpoll_setup(np, port->dev); |
1048 | if (err) { | 1047 | if (err) { |
1049 | kfree(np); | 1048 | kfree(np); |
1050 | return err; | 1049 | return err; |
@@ -1067,8 +1066,7 @@ static void team_port_disable_netpoll(struct team_port *port) | |||
1067 | kfree(np); | 1066 | kfree(np); |
1068 | } | 1067 | } |
1069 | #else | 1068 | #else |
1070 | static int team_port_enable_netpoll(struct team *team, struct team_port *port, | 1069 | static int team_port_enable_netpoll(struct team *team, struct team_port *port) |
1071 | gfp_t gfp) | ||
1072 | { | 1070 | { |
1073 | return 0; | 1071 | return 0; |
1074 | } | 1072 | } |
@@ -1156,7 +1154,7 @@ static int team_port_add(struct team *team, struct net_device *port_dev) | |||
1156 | goto err_vids_add; | 1154 | goto err_vids_add; |
1157 | } | 1155 | } |
1158 | 1156 | ||
1159 | err = team_port_enable_netpoll(team, port, GFP_KERNEL); | 1157 | err = team_port_enable_netpoll(team, port); |
1160 | if (err) { | 1158 | if (err) { |
1161 | netdev_err(dev, "Failed to enable netpoll on device %s\n", | 1159 | netdev_err(dev, "Failed to enable netpoll on device %s\n", |
1162 | portname); | 1160 | portname); |
@@ -1850,7 +1848,7 @@ static void team_netpoll_cleanup(struct net_device *dev) | |||
1850 | } | 1848 | } |
1851 | 1849 | ||
1852 | static int team_netpoll_setup(struct net_device *dev, | 1850 | static int team_netpoll_setup(struct net_device *dev, |
1853 | struct netpoll_info *npifo, gfp_t gfp) | 1851 | struct netpoll_info *npifo) |
1854 | { | 1852 | { |
1855 | struct team *team = netdev_priv(dev); | 1853 | struct team *team = netdev_priv(dev); |
1856 | struct team_port *port; | 1854 | struct team_port *port; |
@@ -1858,7 +1856,7 @@ static int team_netpoll_setup(struct net_device *dev, | |||
1858 | 1856 | ||
1859 | mutex_lock(&team->lock); | 1857 | mutex_lock(&team->lock); |
1860 | list_for_each_entry(port, &team->port_list, list) { | 1858 | list_for_each_entry(port, &team->port_list, list) { |
1861 | err = team_port_enable_netpoll(team, port, gfp); | 1859 | err = team_port_enable_netpoll(team, port); |
1862 | if (err) { | 1860 | if (err) { |
1863 | __team_netpoll_cleanup(team); | 1861 | __team_netpoll_cleanup(team); |
1864 | break; | 1862 | break; |
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 159c7e7945f8..0d8c8718980a 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h | |||
@@ -1037,8 +1037,7 @@ struct net_device_ops { | |||
1037 | #ifdef CONFIG_NET_POLL_CONTROLLER | 1037 | #ifdef CONFIG_NET_POLL_CONTROLLER |
1038 | void (*ndo_poll_controller)(struct net_device *dev); | 1038 | void (*ndo_poll_controller)(struct net_device *dev); |
1039 | int (*ndo_netpoll_setup)(struct net_device *dev, | 1039 | int (*ndo_netpoll_setup)(struct net_device *dev, |
1040 | struct netpoll_info *info, | 1040 | struct netpoll_info *info); |
1041 | gfp_t gfp); | ||
1042 | void (*ndo_netpoll_cleanup)(struct net_device *dev); | 1041 | void (*ndo_netpoll_cleanup)(struct net_device *dev); |
1043 | #endif | 1042 | #endif |
1044 | #ifdef CONFIG_NET_RX_BUSY_POLL | 1043 | #ifdef CONFIG_NET_RX_BUSY_POLL |
diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h index 1b475a5a7239..893b9e66060e 100644 --- a/include/linux/netpoll.h +++ b/include/linux/netpoll.h | |||
@@ -57,7 +57,7 @@ static inline void netpoll_rx_enable(struct net_device *dev) { return; } | |||
57 | void netpoll_send_udp(struct netpoll *np, const char *msg, int len); | 57 | void netpoll_send_udp(struct netpoll *np, const char *msg, int len); |
58 | void netpoll_print_options(struct netpoll *np); | 58 | void netpoll_print_options(struct netpoll *np); |
59 | int netpoll_parse_options(struct netpoll *np, char *opt); | 59 | int netpoll_parse_options(struct netpoll *np, char *opt); |
60 | int __netpoll_setup(struct netpoll *np, struct net_device *ndev, gfp_t gfp); | 60 | int __netpoll_setup(struct netpoll *np, struct net_device *ndev); |
61 | int netpoll_setup(struct netpoll *np); | 61 | int netpoll_setup(struct netpoll *np); |
62 | void __netpoll_cleanup(struct netpoll *np); | 62 | void __netpoll_cleanup(struct netpoll *np); |
63 | void __netpoll_free_async(struct netpoll *np); | 63 | void __netpoll_free_async(struct netpoll *np); |
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 4f3e9073cb49..a78bebeca4d9 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c | |||
@@ -707,20 +707,19 @@ static void vlan_dev_poll_controller(struct net_device *dev) | |||
707 | return; | 707 | return; |
708 | } | 708 | } |
709 | 709 | ||
710 | static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *npinfo, | 710 | static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *npinfo) |
711 | gfp_t gfp) | ||
712 | { | 711 | { |
713 | struct vlan_dev_priv *vlan = vlan_dev_priv(dev); | 712 | struct vlan_dev_priv *vlan = vlan_dev_priv(dev); |
714 | struct net_device *real_dev = vlan->real_dev; | 713 | struct net_device *real_dev = vlan->real_dev; |
715 | struct netpoll *netpoll; | 714 | struct netpoll *netpoll; |
716 | int err = 0; | 715 | int err = 0; |
717 | 716 | ||
718 | netpoll = kzalloc(sizeof(*netpoll), gfp); | 717 | netpoll = kzalloc(sizeof(*netpoll), GFP_KERNEL); |
719 | err = -ENOMEM; | 718 | err = -ENOMEM; |
720 | if (!netpoll) | 719 | if (!netpoll) |
721 | goto out; | 720 | goto out; |
722 | 721 | ||
723 | err = __netpoll_setup(netpoll, real_dev, gfp); | 722 | err = __netpoll_setup(netpoll, real_dev); |
724 | if (err) { | 723 | if (err) { |
725 | kfree(netpoll); | 724 | kfree(netpoll); |
726 | goto out; | 725 | goto out; |
diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index f2a08477e0f5..0dd01a05bd59 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c | |||
@@ -218,16 +218,16 @@ static void br_netpoll_cleanup(struct net_device *dev) | |||
218 | br_netpoll_disable(p); | 218 | br_netpoll_disable(p); |
219 | } | 219 | } |
220 | 220 | ||
221 | static int __br_netpoll_enable(struct net_bridge_port *p, gfp_t gfp) | 221 | static int __br_netpoll_enable(struct net_bridge_port *p) |
222 | { | 222 | { |
223 | struct netpoll *np; | 223 | struct netpoll *np; |
224 | int err; | 224 | int err; |
225 | 225 | ||
226 | np = kzalloc(sizeof(*p->np), gfp); | 226 | np = kzalloc(sizeof(*p->np), GFP_KERNEL); |
227 | if (!np) | 227 | if (!np) |
228 | return -ENOMEM; | 228 | return -ENOMEM; |
229 | 229 | ||
230 | err = __netpoll_setup(np, p->dev, gfp); | 230 | err = __netpoll_setup(np, p->dev); |
231 | if (err) { | 231 | if (err) { |
232 | kfree(np); | 232 | kfree(np); |
233 | return err; | 233 | return err; |
@@ -237,16 +237,15 @@ static int __br_netpoll_enable(struct net_bridge_port *p, gfp_t gfp) | |||
237 | return err; | 237 | return err; |
238 | } | 238 | } |
239 | 239 | ||
240 | int br_netpoll_enable(struct net_bridge_port *p, gfp_t gfp) | 240 | int br_netpoll_enable(struct net_bridge_port *p) |
241 | { | 241 | { |
242 | if (!p->br->dev->npinfo) | 242 | if (!p->br->dev->npinfo) |
243 | return 0; | 243 | return 0; |
244 | 244 | ||
245 | return __br_netpoll_enable(p, gfp); | 245 | return __br_netpoll_enable(p); |
246 | } | 246 | } |
247 | 247 | ||
248 | static int br_netpoll_setup(struct net_device *dev, struct netpoll_info *ni, | 248 | static int br_netpoll_setup(struct net_device *dev, struct netpoll_info *ni) |
249 | gfp_t gfp) | ||
250 | { | 249 | { |
251 | struct net_bridge *br = netdev_priv(dev); | 250 | struct net_bridge *br = netdev_priv(dev); |
252 | struct net_bridge_port *p; | 251 | struct net_bridge_port *p; |
@@ -255,7 +254,7 @@ static int br_netpoll_setup(struct net_device *dev, struct netpoll_info *ni, | |||
255 | list_for_each_entry(p, &br->port_list, list) { | 254 | list_for_each_entry(p, &br->port_list, list) { |
256 | if (!p->dev) | 255 | if (!p->dev) |
257 | continue; | 256 | continue; |
258 | err = __br_netpoll_enable(p, gfp); | 257 | err = __br_netpoll_enable(p); |
259 | if (err) | 258 | if (err) |
260 | goto fail; | 259 | goto fail; |
261 | } | 260 | } |
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 54d207d3a31c..5262b8617eb9 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c | |||
@@ -366,7 +366,7 @@ int br_add_if(struct net_bridge *br, struct net_device *dev) | |||
366 | if (err) | 366 | if (err) |
367 | goto err2; | 367 | goto err2; |
368 | 368 | ||
369 | err = br_netpoll_enable(p, GFP_KERNEL); | 369 | err = br_netpoll_enable(p); |
370 | if (err) | 370 | if (err) |
371 | goto err3; | 371 | goto err3; |
372 | 372 | ||
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index e1ca1dc916a4..06811d79f89f 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h | |||
@@ -349,7 +349,7 @@ static inline void br_netpoll_send_skb(const struct net_bridge_port *p, | |||
349 | netpoll_send_skb(np, skb); | 349 | netpoll_send_skb(np, skb); |
350 | } | 350 | } |
351 | 351 | ||
352 | int br_netpoll_enable(struct net_bridge_port *p, gfp_t gfp); | 352 | int br_netpoll_enable(struct net_bridge_port *p); |
353 | void br_netpoll_disable(struct net_bridge_port *p); | 353 | void br_netpoll_disable(struct net_bridge_port *p); |
354 | #else | 354 | #else |
355 | static inline void br_netpoll_send_skb(const struct net_bridge_port *p, | 355 | static inline void br_netpoll_send_skb(const struct net_bridge_port *p, |
@@ -357,7 +357,7 @@ static inline void br_netpoll_send_skb(const struct net_bridge_port *p, | |||
357 | { | 357 | { |
358 | } | 358 | } |
359 | 359 | ||
360 | static inline int br_netpoll_enable(struct net_bridge_port *p, gfp_t gfp) | 360 | static inline int br_netpoll_enable(struct net_bridge_port *p) |
361 | { | 361 | { |
362 | return 0; | 362 | return 0; |
363 | } | 363 | } |
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 41c4e9ce1141..2c6379da295c 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c | |||
@@ -584,7 +584,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt) | |||
584 | } | 584 | } |
585 | EXPORT_SYMBOL(netpoll_parse_options); | 585 | EXPORT_SYMBOL(netpoll_parse_options); |
586 | 586 | ||
587 | int __netpoll_setup(struct netpoll *np, struct net_device *ndev, gfp_t gfp) | 587 | int __netpoll_setup(struct netpoll *np, struct net_device *ndev) |
588 | { | 588 | { |
589 | struct netpoll_info *npinfo; | 589 | struct netpoll_info *npinfo; |
590 | const struct net_device_ops *ops; | 590 | const struct net_device_ops *ops; |
@@ -603,7 +603,7 @@ int __netpoll_setup(struct netpoll *np, struct net_device *ndev, gfp_t gfp) | |||
603 | } | 603 | } |
604 | 604 | ||
605 | if (!ndev->npinfo) { | 605 | if (!ndev->npinfo) { |
606 | npinfo = kmalloc(sizeof(*npinfo), gfp); | 606 | npinfo = kmalloc(sizeof(*npinfo), GFP_KERNEL); |
607 | if (!npinfo) { | 607 | if (!npinfo) { |
608 | err = -ENOMEM; | 608 | err = -ENOMEM; |
609 | goto out; | 609 | goto out; |
@@ -617,7 +617,7 @@ int __netpoll_setup(struct netpoll *np, struct net_device *ndev, gfp_t gfp) | |||
617 | 617 | ||
618 | ops = np->dev->netdev_ops; | 618 | ops = np->dev->netdev_ops; |
619 | if (ops->ndo_netpoll_setup) { | 619 | if (ops->ndo_netpoll_setup) { |
620 | err = ops->ndo_netpoll_setup(ndev, npinfo, gfp); | 620 | err = ops->ndo_netpoll_setup(ndev, npinfo); |
621 | if (err) | 621 | if (err) |
622 | goto free_npinfo; | 622 | goto free_npinfo; |
623 | } | 623 | } |
@@ -749,7 +749,7 @@ int netpoll_setup(struct netpoll *np) | |||
749 | /* fill up the skb queue */ | 749 | /* fill up the skb queue */ |
750 | refill_skbs(); | 750 | refill_skbs(); |
751 | 751 | ||
752 | err = __netpoll_setup(np, ndev, GFP_KERNEL); | 752 | err = __netpoll_setup(np, ndev); |
753 | if (err) | 753 | if (err) |
754 | goto put; | 754 | goto put; |
755 | 755 | ||