diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-03-11 03:43:16 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-03-15 12:06:02 -0400 |
commit | 119fa3c922ff53a334507e198b2e3c66e99f54dc (patch) | |
tree | 43c5458c75b0ec7606d401d420c61d94f402ca86 /tools/perf/util/evlist.c | |
parent | 6ef73ec449af998ca34673636d00decc8e808544 (diff) |
perf evlist: Do not pass struct record_opts to perf_evlist__prepare_workload()
Since it's only used for checking ->pipe_output, we can pass the result
directly.
Now the perf_evlist__prepare_workload() don't have a dependency of
struct perf_record_opts, it can be called from other places like perf
stat.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1362987798-24969-5-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/evlist.c')
-rw-r--r-- | tools/perf/util/evlist.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 291884c804e9..9a337f091b22 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c | |||
@@ -746,8 +746,7 @@ out_err: | |||
746 | 746 | ||
747 | int perf_evlist__prepare_workload(struct perf_evlist *evlist, | 747 | int perf_evlist__prepare_workload(struct perf_evlist *evlist, |
748 | struct perf_target *target, | 748 | struct perf_target *target, |
749 | struct perf_record_opts *opts, | 749 | const char *argv[], bool pipe_output) |
750 | const char *argv[]) | ||
751 | { | 750 | { |
752 | int child_ready_pipe[2], go_pipe[2]; | 751 | int child_ready_pipe[2], go_pipe[2]; |
753 | char bf; | 752 | char bf; |
@@ -769,7 +768,7 @@ int perf_evlist__prepare_workload(struct perf_evlist *evlist, | |||
769 | } | 768 | } |
770 | 769 | ||
771 | if (!evlist->workload.pid) { | 770 | if (!evlist->workload.pid) { |
772 | if (opts->pipe_output) | 771 | if (pipe_output) |
773 | dup2(2, 1); | 772 | dup2(2, 1); |
774 | 773 | ||
775 | close(child_ready_pipe[0]); | 774 | close(child_ready_pipe[0]); |