6lowpan: cleanup lowpan_header_decompress

This patch changes the lowpan_header_decompress function by removing
inklayer related information from parameters. This is currently for
supporting short and extended address for iphc handling in 802154.
We don't support short address handling anyway right now, but there
exists already code for handling short addresses in
lowpan_header_decompress.

The address parameters are also changed to a void pointer, so 6LoWPAN
linklayer specific code can put complex structures as these parameters
and cast it again inside the generic code by evaluating linklayer type
before. The order is also changed by destination address at first and
then source address, which is the same like all others functions where
destination is always the first, memcpy, dev_hard_header,
lowpan_header_compress, etc.

This patch also moves the fetching of iphc values from 6LoWPAN linklayer
specific code into the generic branch.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

1 files changed, 1 insertions, 25 deletions

diff --git a/net/ieee802154/6lowpan/rx.c b/net/ieee802154/6lowpan/rx.c
index 65d55e05516c..403f17126433 100644
--- a/net/ieee802154/6lowpan/rx.c
+++ b/net/ieee802154/6lowpan/rx.c
@@ -90,36 +90,12 @@ static lowpan_rx_result lowpan_rx_h_frag(struct sk_buff *skb)
 
 int lowpan_iphc_decompress(struct sk_buff *skb)
 {
-        struct ieee802154_addr_sa sa, da;
         struct ieee802154_hdr hdr;
-        u8 iphc0, iphc1;
-        void *sap, *dap;
 
         if (ieee802154_hdr_peek_addrs(skb, &hdr) < 0)
                 return -EINVAL;
 
-        raw_dump_table(__func__, "raw skb data dump", skb->data, skb->len);
-
-        if (lowpan_fetch_skb_u8(skb, &iphc0) ||
-            lowpan_fetch_skb_u8(skb, &iphc1))
-                return -EINVAL;
-
-        ieee802154_addr_to_sa(&sa, &hdr.source);
-        ieee802154_addr_to_sa(&da, &hdr.dest);
-
-        if (sa.addr_type == IEEE802154_ADDR_SHORT)
-                sap = &sa.short_addr;
-        else
-                sap = &sa.hwaddr;
-
-        if (da.addr_type == IEEE802154_ADDR_SHORT)
-                dap = &da.short_addr;
-        else
-                dap = &da.hwaddr;
-
-        return lowpan_header_decompress(skb, skb->dev, sap, sa.addr_type,
-                                        IEEE802154_ADDR_LEN, dap, da.addr_type,
-                                        IEEE802154_ADDR_LEN, iphc0, iphc1);
+        return lowpan_header_decompress(skb, skb->dev, &hdr.dest, &hdr.source);
 }
 
 static lowpan_rx_result lowpan_rx_h_iphc(struct sk_buff *skb)