diff options
author | Kinglong Mee <kinglongmee@gmail.com> | 2014-07-07 10:10:56 -0400 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2014-07-09 20:55:08 -0400 |
commit | 01529e3f817908b394221b0a5d985ae3541641cc (patch) | |
tree | ad2398d812af60dcb48daa047301c19124b4708b /fs/nfsd/nfs4xdr.c | |
parent | 0fe492db6003218d5c36765c09cce3a5a9f8a2eb (diff) |
NFSD: Fix memory leak in encoding denied lock
Commit 8c7424cff6 (nfsd4: don't try to encode conflicting owner if low on space)
forgot free conf->data in nfsd4_encode_lockt and before sign conf->data to NULL
in nfsd4_encode_lock_denied.
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfs4xdr.c')
-rw-r--r-- | fs/nfsd/nfs4xdr.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 21ffb9b9b768..1ad7bd4e346f 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c | |||
@@ -2874,6 +2874,7 @@ again: | |||
2874 | * return the conflicting open: | 2874 | * return the conflicting open: |
2875 | */ | 2875 | */ |
2876 | if (conf->len) { | 2876 | if (conf->len) { |
2877 | kfree(conf->data); | ||
2877 | conf->len = 0; | 2878 | conf->len = 0; |
2878 | conf->data = NULL; | 2879 | conf->data = NULL; |
2879 | goto again; | 2880 | goto again; |
@@ -2886,6 +2887,7 @@ again: | |||
2886 | if (conf->len) { | 2887 | if (conf->len) { |
2887 | p = xdr_encode_opaque_fixed(p, &ld->ld_clientid, 8); | 2888 | p = xdr_encode_opaque_fixed(p, &ld->ld_clientid, 8); |
2888 | p = xdr_encode_opaque(p, conf->data, conf->len); | 2889 | p = xdr_encode_opaque(p, conf->data, conf->len); |
2890 | kfree(conf->data); | ||
2889 | } else { /* non - nfsv4 lock in conflict, no clientid nor owner */ | 2891 | } else { /* non - nfsv4 lock in conflict, no clientid nor owner */ |
2890 | p = xdr_encode_hyper(p, (u64)0); /* clientid */ | 2892 | p = xdr_encode_hyper(p, (u64)0); /* clientid */ |
2891 | *p++ = cpu_to_be32(0); /* length of owner name */ | 2893 | *p++ = cpu_to_be32(0); /* length of owner name */ |
@@ -2902,7 +2904,7 @@ nfsd4_encode_lock(struct nfsd4_compoundres *resp, __be32 nfserr, struct nfsd4_lo | |||
2902 | nfserr = nfsd4_encode_stateid(xdr, &lock->lk_resp_stateid); | 2904 | nfserr = nfsd4_encode_stateid(xdr, &lock->lk_resp_stateid); |
2903 | else if (nfserr == nfserr_denied) | 2905 | else if (nfserr == nfserr_denied) |
2904 | nfserr = nfsd4_encode_lock_denied(xdr, &lock->lk_denied); | 2906 | nfserr = nfsd4_encode_lock_denied(xdr, &lock->lk_denied); |
2905 | kfree(lock->lk_denied.ld_owner.data); | 2907 | |
2906 | return nfserr; | 2908 | return nfserr; |
2907 | } | 2909 | } |
2908 | 2910 | ||