diff options
author | Joe Perches <joe@perches.com> | 2013-04-30 18:27:55 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-04-30 20:04:05 -0400 |
commit | d614267329f2bee7a082ed8781c581c0f3aaa808 (patch) | |
tree | edade57808a2a2e327daf83991a31a76660b7a41 /fs/hfs/btree.c | |
parent | c2b3e1f76e5c90215bc7f740b376c0220eb8a8e3 (diff) |
hfs/hfsplus: convert printks to pr_<level>
Use a more current logging style.
Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
hfsplus now uses "hfsplus: " for all messages.
Coalesce formats.
Prefix debugging messages too.
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/hfs/btree.c')
-rw-r--r-- | fs/hfs/btree.c | 29 |
1 files changed, 16 insertions, 13 deletions
diff --git a/fs/hfs/btree.c b/fs/hfs/btree.c index 07d94ce1d278..1ab19e660e69 100644 --- a/fs/hfs/btree.c +++ b/fs/hfs/btree.c | |||
@@ -48,7 +48,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke | |||
48 | mdb->drXTFlSize, be32_to_cpu(mdb->drXTClpSiz)); | 48 | mdb->drXTFlSize, be32_to_cpu(mdb->drXTClpSiz)); |
49 | if (HFS_I(tree->inode)->alloc_blocks > | 49 | if (HFS_I(tree->inode)->alloc_blocks > |
50 | HFS_I(tree->inode)->first_blocks) { | 50 | HFS_I(tree->inode)->first_blocks) { |
51 | printk(KERN_ERR "hfs: invalid btree extent records\n"); | 51 | pr_err("invalid btree extent records\n"); |
52 | unlock_new_inode(tree->inode); | 52 | unlock_new_inode(tree->inode); |
53 | goto free_inode; | 53 | goto free_inode; |
54 | } | 54 | } |
@@ -60,8 +60,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke | |||
60 | mdb->drCTFlSize, be32_to_cpu(mdb->drCTClpSiz)); | 60 | mdb->drCTFlSize, be32_to_cpu(mdb->drCTClpSiz)); |
61 | 61 | ||
62 | if (!HFS_I(tree->inode)->first_blocks) { | 62 | if (!HFS_I(tree->inode)->first_blocks) { |
63 | printk(KERN_ERR "hfs: invalid btree extent records " | 63 | pr_err("invalid btree extent records (0 size)\n"); |
64 | "(0 size).\n"); | ||
65 | unlock_new_inode(tree->inode); | 64 | unlock_new_inode(tree->inode); |
66 | goto free_inode; | 65 | goto free_inode; |
67 | } | 66 | } |
@@ -100,15 +99,15 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke | |||
100 | switch (id) { | 99 | switch (id) { |
101 | case HFS_EXT_CNID: | 100 | case HFS_EXT_CNID: |
102 | if (tree->max_key_len != HFS_MAX_EXT_KEYLEN) { | 101 | if (tree->max_key_len != HFS_MAX_EXT_KEYLEN) { |
103 | printk(KERN_ERR "hfs: invalid extent max_key_len %d\n", | 102 | pr_err("invalid extent max_key_len %d\n", |
104 | tree->max_key_len); | 103 | tree->max_key_len); |
105 | goto fail_page; | 104 | goto fail_page; |
106 | } | 105 | } |
107 | break; | 106 | break; |
108 | case HFS_CAT_CNID: | 107 | case HFS_CAT_CNID: |
109 | if (tree->max_key_len != HFS_MAX_CAT_KEYLEN) { | 108 | if (tree->max_key_len != HFS_MAX_CAT_KEYLEN) { |
110 | printk(KERN_ERR "hfs: invalid catalog max_key_len %d\n", | 109 | pr_err("invalid catalog max_key_len %d\n", |
111 | tree->max_key_len); | 110 | tree->max_key_len); |
112 | goto fail_page; | 111 | goto fail_page; |
113 | } | 112 | } |
114 | break; | 113 | break; |
@@ -146,8 +145,9 @@ void hfs_btree_close(struct hfs_btree *tree) | |||
146 | while ((node = tree->node_hash[i])) { | 145 | while ((node = tree->node_hash[i])) { |
147 | tree->node_hash[i] = node->next_hash; | 146 | tree->node_hash[i] = node->next_hash; |
148 | if (atomic_read(&node->refcnt)) | 147 | if (atomic_read(&node->refcnt)) |
149 | printk(KERN_ERR "hfs: node %d:%d still has %d user(s)!\n", | 148 | pr_err("node %d:%d still has %d user(s)!\n", |
150 | node->tree->cnid, node->this, atomic_read(&node->refcnt)); | 149 | node->tree->cnid, node->this, |
150 | atomic_read(&node->refcnt)); | ||
151 | hfs_bnode_free(node); | 151 | hfs_bnode_free(node); |
152 | tree->node_hash_cnt--; | 152 | tree->node_hash_cnt--; |
153 | } | 153 | } |
@@ -290,7 +290,7 @@ struct hfs_bnode *hfs_bmap_alloc(struct hfs_btree *tree) | |||
290 | kunmap(*pagep); | 290 | kunmap(*pagep); |
291 | nidx = node->next; | 291 | nidx = node->next; |
292 | if (!nidx) { | 292 | if (!nidx) { |
293 | printk(KERN_DEBUG "hfs: create new bmap node...\n"); | 293 | printk(KERN_DEBUG "create new bmap node...\n"); |
294 | next_node = hfs_bmap_new_bmap(node, idx); | 294 | next_node = hfs_bmap_new_bmap(node, idx); |
295 | } else | 295 | } else |
296 | next_node = hfs_bnode_find(tree, nidx); | 296 | next_node = hfs_bnode_find(tree, nidx); |
@@ -331,7 +331,8 @@ void hfs_bmap_free(struct hfs_bnode *node) | |||
331 | hfs_bnode_put(node); | 331 | hfs_bnode_put(node); |
332 | if (!i) { | 332 | if (!i) { |
333 | /* panic */; | 333 | /* panic */; |
334 | printk(KERN_CRIT "hfs: unable to free bnode %u. bmap not found!\n", node->this); | 334 | pr_crit("unable to free bnode %u. bmap not found!\n", |
335 | node->this); | ||
335 | return; | 336 | return; |
336 | } | 337 | } |
337 | node = hfs_bnode_find(tree, i); | 338 | node = hfs_bnode_find(tree, i); |
@@ -339,7 +340,8 @@ void hfs_bmap_free(struct hfs_bnode *node) | |||
339 | return; | 340 | return; |
340 | if (node->type != HFS_NODE_MAP) { | 341 | if (node->type != HFS_NODE_MAP) { |
341 | /* panic */; | 342 | /* panic */; |
342 | printk(KERN_CRIT "hfs: invalid bmap found! (%u,%d)\n", node->this, node->type); | 343 | pr_crit("invalid bmap found! (%u,%d)\n", |
344 | node->this, node->type); | ||
343 | hfs_bnode_put(node); | 345 | hfs_bnode_put(node); |
344 | return; | 346 | return; |
345 | } | 347 | } |
@@ -352,7 +354,8 @@ void hfs_bmap_free(struct hfs_bnode *node) | |||
352 | m = 1 << (~nidx & 7); | 354 | m = 1 << (~nidx & 7); |
353 | byte = data[off]; | 355 | byte = data[off]; |
354 | if (!(byte & m)) { | 356 | if (!(byte & m)) { |
355 | printk(KERN_CRIT "hfs: trying to free free bnode %u(%d)\n", node->this, node->type); | 357 | pr_crit("trying to free free bnode %u(%d)\n", |
358 | node->this, node->type); | ||
356 | kunmap(page); | 359 | kunmap(page); |
357 | hfs_bnode_put(node); | 360 | hfs_bnode_put(node); |
358 | return; | 361 | return; |