diff options
author | Oleg Nesterov <oleg@redhat.com> | 2014-01-23 18:55:34 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-01-23 19:37:01 -0500 |
commit | 942be3875a1931c379bbc37053829dd6847e0f3f (patch) | |
tree | b601300c01f71ee23f817fa104fc52329ed1d747 /fs/exec.c | |
parent | 7288e1187ba935996232246916418c64bb88da30 (diff) |
coredump: make __get_dumpable/get_dumpable inline, kill fs/coredump.h
1. Remove fs/coredump.h. It is not clear why do we need it,
it only declares __get_dumpable(), signal.c includes it
for no reason.
2. Now that get_dumpable() and __get_dumpable() are really
trivial make them inline in linux/sched.h.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Alex Kelly <alex.page.kelly@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Petr Matousek <pmatouse@redhat.com>
Cc: Vasily Kulikov <segoon@openwall.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/exec.c')
-rw-r--r-- | fs/exec.c | 18 |
1 files changed, 0 insertions, 18 deletions
@@ -62,7 +62,6 @@ | |||
62 | 62 | ||
63 | #include <trace/events/task.h> | 63 | #include <trace/events/task.h> |
64 | #include "internal.h" | 64 | #include "internal.h" |
65 | #include "coredump.h" | ||
66 | 65 | ||
67 | #include <trace/events/sched.h> | 66 | #include <trace/events/sched.h> |
68 | 67 | ||
@@ -1609,7 +1608,6 @@ void set_binfmt(struct linux_binfmt *new) | |||
1609 | if (new) | 1608 | if (new) |
1610 | __module_get(new->module); | 1609 | __module_get(new->module); |
1611 | } | 1610 | } |
1612 | |||
1613 | EXPORT_SYMBOL(set_binfmt); | 1611 | EXPORT_SYMBOL(set_binfmt); |
1614 | 1612 | ||
1615 | /* | 1613 | /* |
@@ -1628,22 +1626,6 @@ void set_dumpable(struct mm_struct *mm, int value) | |||
1628 | } while (cmpxchg(&mm->flags, old, new) != old); | 1626 | } while (cmpxchg(&mm->flags, old, new) != old); |
1629 | } | 1627 | } |
1630 | 1628 | ||
1631 | int __get_dumpable(unsigned long mm_flags) | ||
1632 | { | ||
1633 | return mm_flags & MMF_DUMPABLE_MASK; | ||
1634 | } | ||
1635 | |||
1636 | /* | ||
1637 | * This returns the actual value of the suid_dumpable flag. For things | ||
1638 | * that are using this for checking for privilege transitions, it must | ||
1639 | * test against SUID_DUMP_USER rather than treating it as a boolean | ||
1640 | * value. | ||
1641 | */ | ||
1642 | int get_dumpable(struct mm_struct *mm) | ||
1643 | { | ||
1644 | return __get_dumpable(mm->flags); | ||
1645 | } | ||
1646 | |||
1647 | SYSCALL_DEFINE3(execve, | 1629 | SYSCALL_DEFINE3(execve, |
1648 | const char __user *, filename, | 1630 | const char __user *, filename, |
1649 | const char __user *const __user *, argv, | 1631 | const char __user *const __user *, argv, |