diff options
author | Sachin Kamat <sachin.kamat@linaro.org> | 2013-03-04 00:06:41 -0500 |
---|---|---|
committer | Wim Van Sebroeck <wim@iguana.be> | 2013-05-09 02:12:00 -0400 |
commit | 6330c7070be6783b82025d2bc259db8413c00182 (patch) | |
tree | 32ef8ae643db47f6c8176b15ae22094b58fefa8c /drivers/watchdog/shwdt.c | |
parent | e0fd9affeb64088eff407dfc98bbd3a5c17ea479 (diff) |
watchdog: Convert to devm_ioremap_resource()
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Gabor Juhos <juhosg@openwrt.org>
Cc: Paul Mundt <lethal@linux-sh.org>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/shwdt.c')
-rw-r--r-- | drivers/watchdog/shwdt.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/watchdog/shwdt.c b/drivers/watchdog/shwdt.c index 6a89e4045fbd..6185af2b3310 100644 --- a/drivers/watchdog/shwdt.c +++ b/drivers/watchdog/shwdt.c | |||
@@ -34,6 +34,7 @@ | |||
34 | #include <linux/slab.h> | 34 | #include <linux/slab.h> |
35 | #include <linux/io.h> | 35 | #include <linux/io.h> |
36 | #include <linux/clk.h> | 36 | #include <linux/clk.h> |
37 | #include <linux/err.h> | ||
37 | #include <asm/watchdog.h> | 38 | #include <asm/watchdog.h> |
38 | 39 | ||
39 | #define DRV_NAME "sh-wdt" | 40 | #define DRV_NAME "sh-wdt" |
@@ -249,9 +250,9 @@ static int sh_wdt_probe(struct platform_device *pdev) | |||
249 | wdt->clk = NULL; | 250 | wdt->clk = NULL; |
250 | } | 251 | } |
251 | 252 | ||
252 | wdt->base = devm_request_and_ioremap(wdt->dev, res); | 253 | wdt->base = devm_ioremap_resource(wdt->dev, res); |
253 | if (unlikely(!wdt->base)) { | 254 | if (IS_ERR(wdt->base)) { |
254 | rc = -EADDRNOTAVAIL; | 255 | rc = PTR_ERR(wdt->base); |
255 | goto err; | 256 | goto err; |
256 | } | 257 | } |
257 | 258 | ||