USB: EHCI: convert singly-linked lists to list_heads

This patch (as1664) converts ehci-hcd's async_unlink, async_iaa, and
intr_unlink from singly-linked lists to standard doubly-linked
list_heads.  Originally it didn't seem necessary to use list_heads,
because items are always added to and removed from these lists in FIFO
order.  But now with more list processing going on, it's easier to use
the standard routines than continue with a roll-your-own approach.

I don't know if the code ends up being notably shorter, but the
patterns will be more familiar to any kernel hacker.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 6 insertions, 5 deletions

diff --git a/drivers/usb/host/ehci-timer.c b/drivers/usb/host/ehci-timer.c
index e7363332887e..f63a98353efd 100644
--- a/drivers/usb/host/ehci-timer.c
+++ b/drivers/usb/host/ehci-timer.c
@@ -229,18 +229,19 @@ static void ehci_handle_intr_unlinks(struct ehci_hcd *ehci)
          * process all the QHs on the list.
          */
         ehci->intr_unlinking = true;
-        while (ehci->intr_unlink) {
-                struct ehci_qh  *qh = ehci->intr_unlink;
+        while (!list_empty(&ehci->intr_unlink)) {
+                struct ehci_qh  *qh;
 
+                qh = list_first_entry(&ehci->intr_unlink, struct ehci_qh,
+                                unlink_node);
                 if (!stopped && qh->unlink_cycle == ehci->intr_unlink_cycle)
                         break;
-                ehci->intr_unlink = qh->unlink_next;
-                qh->unlink_next = NULL;
+                list_del(&qh->unlink_node);
                 end_unlink_intr(ehci, qh);
         }
 
         /* Handle remaining entries later */
-        if (ehci->intr_unlink) {
+        if (!list_empty(&ehci->intr_unlink)) {
                 ehci_enable_event(ehci, EHCI_HRTIMER_UNLINK_INTR, true);
                 ++ehci->intr_unlink_cycle;
         }