tty/vt/keyboard: use memdup_user().

Use memdup_user to duplicate a memory region from user-space to
kernel-space, instead of open coding using kmalloc & copy_from_user.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 4 insertions, 10 deletions

diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
index cd08c103eb47..89a7ab007ff4 100644
--- a/drivers/tty/vt/keyboard.c
+++ b/drivers/tty/vt/keyboard.c
@@ -1745,16 +1745,10 @@ int vt_do_diacrit(unsigned int cmd, void __user *udp, int perm)
                         return -EINVAL;
 
                 if (ct) {
-                        buf = kmalloc(ct * sizeof(struct kbdiacruc),
-                                                                GFP_KERNEL);
-                        if (buf == NULL)
-                                return -ENOMEM;
-
-                        if (copy_from_user(buf, a->kbdiacruc,
-                                        ct * sizeof(struct kbdiacruc))) {
-                                kfree(buf);
-                                return -EFAULT;
-                        }
+                        buf = memdup_user(a->kbdiacruc,
+                                          ct * sizeof(struct kbdiacruc));
+                        if (IS_ERR(buf))
+                                return PTR_ERR(buf);
                 } 
                 spin_lock_irqsave(&kbd_event_lock, flags);
                 if (ct)