aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/regulator
diff options
context:
space:
mode:
authorMatthias Kaehlcke <mka@chromium.org>2016-09-14 12:52:07 -0400
committerMark Brown <broonie@kernel.org>2016-09-16 12:33:40 -0400
commitd89564efe79419a093e966a959bf5ba2c94e693f (patch)
treeac1627d59ba96725a41ebcba16271e0055f7d654 /drivers/regulator
parent31dfe686ed0ba5a796bcfc5a6745e77ddb5daa4e (diff)
regulator: core: Don't skip set_voltage_time when ramp delay disabled
The current code assumes that only the ramp_delay is used to determine the time needed for the voltage to stabilize. This may be true for the calculation done by regulator_set_voltage_time_sel(), however regulators can implement their own set_voltage_time_sel() op which would be skipped if no ramp delay is specified. Remove the check in _regulator_do_set_voltage(), the functions calculating the ramp delay return 0 anyway when the ramp delay is not configured. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
-rw-r--r--drivers/regulator/core.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index b0076ccf896b..df3028b2a8e9 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2804,9 +2804,7 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
2804 goto out; 2804 goto out;
2805 2805
2806 /* Call set_voltage_time_sel if successfully obtained old_selector */ 2806 /* Call set_voltage_time_sel if successfully obtained old_selector */
2807 if (!rdev->constraints->ramp_disable && old_selector >= 0 2807 if (!old_selector >= 0 && old_selector != selector) {
2808 && old_selector != selector) {
2809
2810 delay = ops->set_voltage_time_sel(rdev, 2808 delay = ops->set_voltage_time_sel(rdev,
2811 old_selector, selector); 2809 old_selector, selector);
2812 if (delay < 0) { 2810 if (delay < 0) {
@@ -3051,10 +3049,8 @@ int regulator_set_voltage_time_sel(struct regulator_dev *rdev,
3051 else if (rdev->desc->ramp_delay) 3049 else if (rdev->desc->ramp_delay)
3052 ramp_delay = rdev->desc->ramp_delay; 3050 ramp_delay = rdev->desc->ramp_delay;
3053 3051
3054 if (ramp_delay == 0) { 3052 if (ramp_delay == 0)
3055 rdev_warn(rdev, "ramp_delay not set\n");
3056 return 0; 3053 return 0;
3057 }
3058 3054
3059 /* sanity check */ 3055 /* sanity check */
3060 if (!rdev->desc->ops->list_voltage) 3056 if (!rdev->desc->ops->list_voltage)