diff options
author | Tobias Klauser <tklauser@distanz.ch> | 2014-07-25 04:36:14 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-09-03 14:42:33 -0400 |
commit | 3b7f1016628e04f937bafd468ce6fa437b92e275 (patch) | |
tree | 45cfb89bd40723a61ec93f59a73d2858b2fd2144 /drivers/pci/pci-driver.c | |
parent | 52addcf9d6669fa439387610bc65c92fa0980cef (diff) |
PCI: Remove unnecessary variable in pci_add_dynid()
The variable "retval" in pci_add_dynid() is only used to store the return
value of driver_attach() and is then directly returned. Remove the
variable and directly pass on driver_attach()'s return value.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/pci-driver.c')
-rw-r--r-- | drivers/pci/pci-driver.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index d04c5adafc16..2b3c89425bb5 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c | |||
@@ -55,7 +55,6 @@ int pci_add_dynid(struct pci_driver *drv, | |||
55 | unsigned long driver_data) | 55 | unsigned long driver_data) |
56 | { | 56 | { |
57 | struct pci_dynid *dynid; | 57 | struct pci_dynid *dynid; |
58 | int retval; | ||
59 | 58 | ||
60 | dynid = kzalloc(sizeof(*dynid), GFP_KERNEL); | 59 | dynid = kzalloc(sizeof(*dynid), GFP_KERNEL); |
61 | if (!dynid) | 60 | if (!dynid) |
@@ -73,9 +72,7 @@ int pci_add_dynid(struct pci_driver *drv, | |||
73 | list_add_tail(&dynid->node, &drv->dynids.list); | 72 | list_add_tail(&dynid->node, &drv->dynids.list); |
74 | spin_unlock(&drv->dynids.lock); | 73 | spin_unlock(&drv->dynids.lock); |
75 | 74 | ||
76 | retval = driver_attach(&drv->driver); | 75 | return driver_attach(&drv->driver); |
77 | |||
78 | return retval; | ||
79 | } | 76 | } |
80 | EXPORT_SYMBOL_GPL(pci_add_dynid); | 77 | EXPORT_SYMBOL_GPL(pci_add_dynid); |
81 | 78 | ||