diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-05-04 02:21:02 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-05-04 16:58:56 -0400 |
commit | 58ef6a3f64bd837e107a2bbf0571574850a32b8c (patch) | |
tree | 786af91757a76e41fbe6554bef09f4602f856d31 /drivers/net/usb | |
parent | 614bdd4d6e61d260d82945f5f52a5dc288f64783 (diff) |
usbnet/smsc75xx: silence uninitialized variable warning
If the fn() calls fail then "buf" is uninitialized. Just return early
in that situation.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
-rw-r--r-- | drivers/net/usb/smsc75xx.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c index c369db99c005..9af9799935db 100644 --- a/drivers/net/usb/smsc75xx.c +++ b/drivers/net/usb/smsc75xx.c | |||
@@ -99,9 +99,11 @@ static int __must_check __smsc75xx_read_reg(struct usbnet *dev, u32 index, | |||
99 | ret = fn(dev, USB_VENDOR_REQUEST_READ_REGISTER, USB_DIR_IN | 99 | ret = fn(dev, USB_VENDOR_REQUEST_READ_REGISTER, USB_DIR_IN |
100 | | USB_TYPE_VENDOR | USB_RECIP_DEVICE, | 100 | | USB_TYPE_VENDOR | USB_RECIP_DEVICE, |
101 | 0, index, &buf, 4); | 101 | 0, index, &buf, 4); |
102 | if (unlikely(ret < 0)) | 102 | if (unlikely(ret < 0)) { |
103 | netdev_warn(dev->net, "Failed to read reg index 0x%08x: %d\n", | 103 | netdev_warn(dev->net, "Failed to read reg index 0x%08x: %d\n", |
104 | index, ret); | 104 | index, ret); |
105 | return ret; | ||
106 | } | ||
105 | 107 | ||
106 | le32_to_cpus(&buf); | 108 | le32_to_cpus(&buf); |
107 | *data = buf; | 109 | *data = buf; |