aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/can
diff options
context:
space:
mode:
authorMarek Vasut <marex@denx.de>2016-03-03 14:45:56 -0500
committerMarc Kleine-Budde <mkl@pengutronix.de>2016-03-10 04:19:09 -0500
commitf1deaee0c3ab1950987d7207d613df0417bd251c (patch)
treefdc5a86b42e4cf63e0cf5bd2fdf27f59e61fcb35 /drivers/net/can
parent99312c377f82f91e7754aefe42f64b619b295fd6 (diff)
can: ifi: Fix TX DLC configuration
The TX DLC, the transmission length information, was not written into the transmit configuration register. When using the CAN core with different CAN controller, the receiving CAN controller will receive only the ID part of the CAN frame, but no data at all. This patch adds the TX DLC into the register to fix this issue. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Marc Kleine-Budde <mkl@pengutronix.de> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Oliver Hartkopp <socketcan@hartkopp.net> Cc: Wolfgang Grandegger <wg@grandegger.com> Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can')
-rw-r--r--drivers/net/can/ifi_canfd/ifi_canfd.c14
1 files changed, 6 insertions, 8 deletions
diff --git a/drivers/net/can/ifi_canfd/ifi_canfd.c b/drivers/net/can/ifi_canfd/ifi_canfd.c
index 57581cb80956..fb93122a2bd3 100644
--- a/drivers/net/can/ifi_canfd/ifi_canfd.c
+++ b/drivers/net/can/ifi_canfd/ifi_canfd.c
@@ -749,8 +749,7 @@ static netdev_tx_t ifi_canfd_start_xmit(struct sk_buff *skb,
749{ 749{
750 struct ifi_canfd_priv *priv = netdev_priv(ndev); 750 struct ifi_canfd_priv *priv = netdev_priv(ndev);
751 struct canfd_frame *cf = (struct canfd_frame *)skb->data; 751 struct canfd_frame *cf = (struct canfd_frame *)skb->data;
752 u32 txst, txid; 752 u32 txst, txid, txdlc;
753 u32 txdlc = 0;
754 int i; 753 int i;
755 754
756 if (can_dropped_invalid_skb(ndev, skb)) 755 if (can_dropped_invalid_skb(ndev, skb))
@@ -773,12 +772,11 @@ static netdev_tx_t ifi_canfd_start_xmit(struct sk_buff *skb,
773 txid = cf->can_id & CAN_SFF_MASK; 772 txid = cf->can_id & CAN_SFF_MASK;
774 } 773 }
775 774
776 if (priv->can.ctrlmode & (CAN_CTRLMODE_FD | CAN_CTRLMODE_FD_NON_ISO)) { 775 txdlc = can_len2dlc(cf->len);
777 if (can_is_canfd_skb(skb)) { 776 if ((priv->can.ctrlmode & CAN_CTRLMODE_FD) && can_is_canfd_skb(skb)) {
778 txdlc |= IFI_CANFD_TXFIFO_DLC_EDL; 777 txdlc |= IFI_CANFD_TXFIFO_DLC_EDL;
779 if (cf->flags & CANFD_BRS) 778 if (cf->flags & CANFD_BRS)
780 txdlc |= IFI_CANFD_TXFIFO_DLC_BRS; 779 txdlc |= IFI_CANFD_TXFIFO_DLC_BRS;
781 }
782 } 780 }
783 781
784 if (cf->can_id & CAN_RTR_FLAG) 782 if (cf->can_id & CAN_RTR_FLAG)